Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1405283006: Deprecate SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed)

Created:
5 years, 1 month ago by philipj_slow
Modified:
5 years, 1 month ago
Reviewers:
fs
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, cbentzel+watch_chromium.org, cbiesinger, Inactive, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, jfernandez, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, Manuel Rego, rjwright, rwlbuis, Stephen Chennney, shans, svillar, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Deprecate SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight Intent to Deprecate: https://groups.google.com/a/chromium.org/d/msg/blink-dev/JlAEmQpWMWA/63acYbmdDwAJ Simply using [Deprecate] is unfortunately not supported. Tests are updated to avoid the attributes to the extent possible. BUG=463116 Committed: https://crrev.com/3ea8c5bfc445dcd51c0e16bb2f5eef0b0345f0d1 Cr-Commit-Position: refs/heads/master@{#358333}

Patch Set 1 #

Patch Set 2 : update platform expectation #

Patch Set 3 : update more expectations #

Patch Set 4 : fix the tests instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -29 lines) Patch
M third_party/WebKit/LayoutTests/css3/flexbox/flexitem-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-item-display-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-svg-in-shadow-subtree-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/click-focus-anchor.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/resources/text-based-repaint.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/W3C-SVG-1.1-SE/text-intro-09-b.svg View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/animations/resources/SVGTestCase.js View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/css/cursor-replace.svg View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/animate-reference-crash-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/detached-outermost-svg-crash-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/font-platformDestroy-crash.svg View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/pointer-events-invalid-fill.svg View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/touch-events.html View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/dynamic-updates/resources/SVGTestCase.js View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style.html View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style-expected.txt View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/text/inline-text-destroy-attributes-crash.xhtml View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.cpp View 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.idl View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405283006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405283006/1
5 years, 1 month ago (2015-11-05 12:06:33 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/136518)
5 years, 1 month ago (2015-11-05 13:24:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405283006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405283006/40001
5 years, 1 month ago (2015-11-06 09:25:04 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-06 11:11:22 UTC) #8
philipj_slow
PTAL
5 years, 1 month ago (2015-11-06 11:15:23 UTC) #10
fs
Ouch, that's a lot of CONSOLE warnings in tests... could we try to proactively "fix" ...
5 years, 1 month ago (2015-11-06 11:23:28 UTC) #11
philipj_slow
On 2015/11/06 11:23:28, fs wrote: > Ouch, that's a lot of CONSOLE warnings in tests... ...
5 years, 1 month ago (2015-11-06 14:25:30 UTC) #12
fs
On 2015/11/06 at 14:25:30, philipj wrote: > On 2015/11/06 11:23:28, fs wrote: > > Ouch, ...
5 years, 1 month ago (2015-11-06 14:35:58 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1405283006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1405283006/60001
5 years, 1 month ago (2015-11-06 15:48:36 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-06 16:37:12 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 16:38:13 UTC) #18
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/3ea8c5bfc445dcd51c0e16bb2f5eef0b0345f0d1
Cr-Commit-Position: refs/heads/master@{#358333}

Powered by Google App Engine
This is Rietveld 408576698