third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style.html - Issue 1405283006: Deprecate SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style.html

Issue 1405283006: Deprecate SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the tests instead Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/dynamic-updates/resources/SVGTestCase.js ('k') | third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style.html

diff --git a/third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style.html b/third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style.html

index 16475cb1bf3f39cb91c99a4bf7203ee74b2df4c8..bce3cfd879a659e9b350c33475958a6cf9ea4f2f 100644

--- a/third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style.html

+++ b/third_party/WebKit/LayoutTests/svg/foreignObject/fO-percentage-height-style.html

@@ -10,12 +10,12 @@

description("Test use of percentages inside foreignObject");

var nestedSvg = document.querySelectorAll('svg')[1];

- shouldBe("nestedSvg.offsetHeight", "250");

+ shouldBe("getComputedStyle(nestedSvg).height", "'250px'");

nestedSvg.style.height = "50%";

- shouldBe("nestedSvg.offsetHeight", "125");

+ shouldBe("getComputedStyle(nestedSvg).height", "'125px'");

var foreignObject = nestedSvg.parentNode;

foreignObject.height.baseVal.value = 400;

- shouldBe("nestedSvg.offsetHeight", "200");

+ shouldBe("getComputedStyle(nestedSvg).height", "'200px'");

</script>