third_party/WebKit/LayoutTests/svg/custom/touch-events.html - Issue 1405283006: Deprecate SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/svg/custom/touch-events.html

Issue 1405283006: Deprecate SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix the tests instead Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/custom/pointer-events-invalid-fill.svg ('k') | third_party/WebKit/LayoutTests/svg/dynamic-updates/resources/SVGTestCase.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/svg/custom/touch-events.html

diff --git a/third_party/WebKit/LayoutTests/svg/custom/touch-events.html b/third_party/WebKit/LayoutTests/svg/custom/touch-events.html

index 6d13a69c0f25c405ed81f2512eb354b7fcb3e2cb..9dd4d8a754d48345f1dbfe8319c81d8731470e7a 100644

--- a/third_party/WebKit/LayoutTests/svg/custom/touch-events.html

+++ b/third_party/WebKit/LayoutTests/svg/custom/touch-events.html

@@ -34,8 +34,9 @@

document.write('This test does not work in manual mode.');

} else {

var svg = document.getElementById('svg');

- var positionX = svg.offsetLeft + 30;

- var positionY = svg.offsetTop + 30;

+ var clientRect = svg.getBoundingClientRect();

+ var positionX = clientRect.left + 30;

+ var positionY = clientRect.top + 30;

// Touch, move, end.

eventSender.addTouchPoint(positionX, positionY);

@@ -83,4 +84,4 @@

</svg>

</body>

-</html>

+</html>