Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1405283006: Deprecate SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the tests instead Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/UseCounter.cpp
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp
index 829856f1f48067ca004e3792c2cf8f01886c3449..af9794713c7f69ae739faeb7e32e9f258e860a77 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp
+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp
@@ -924,6 +924,7 @@ String UseCounter::deprecationMessage(Feature feature)
case SVGSMILElementInDocument:
case SVGSMILAnimationInImageRegardlessOfCache:
return "SVG's SMIL animations (<animate>, <set>, etc.) are deprecated and will be removed. Please use CSS animations or Web animations instead.";
+
case PrefixedPerformanceClearResourceTimings:
return replacedBy("Performance.webkitClearResourceTimings", "Performance.clearResourceTimings");
@@ -942,6 +943,21 @@ String UseCounter::deprecationMessage(Feature feature)
case BluetoothDeviceInstanceId:
return replacedBy("BluetoothDevice.instanceID", "BluetoothDevice.id");
+ case V8SVGElement_OffsetParent_AttributeGetter:
+ return "'SVGElement.offsetParent' is deprecated and will be removed in M50, around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details.";
+
+ case V8SVGElement_OffsetTop_AttributeGetter:
+ return "'SVGElement.offsetTop' is deprecated and will be removed in M50, around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details.";
+
+ case V8SVGElement_OffsetLeft_AttributeGetter:
+ return "'SVGElement.offsetLeft' is deprecated and will be removed in M50, around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details.";
+
+ case V8SVGElement_OffsetWidth_AttributeGetter:
+ return "'SVGElement.offsetWidth' is deprecated and will be removed in M50, around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details.";
+
+ case V8SVGElement_OffsetHeight_AttributeGetter:
+ return "'SVGElement.offsetHeight' is deprecated and will be removed in M50, around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details.";
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();

Powered by Google App Engine
This is Rietveld 408576698