Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 1405283006: Deprecate SVGElement.offsetParent/offsetTop/offsetLeft/offsetWidth/offsetHeight (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix the tests instead Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 906 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 917
918 case PrefixedMouseEventMovementX: 918 case PrefixedMouseEventMovementX:
919 return replacedBy("webkitMovementX", "movementX"); 919 return replacedBy("webkitMovementX", "movementX");
920 920
921 case PrefixedMouseEventMovementY: 921 case PrefixedMouseEventMovementY:
922 return replacedBy("webkitMovementY", "movementY"); 922 return replacedBy("webkitMovementY", "movementY");
923 923
924 case SVGSMILElementInDocument: 924 case SVGSMILElementInDocument:
925 case SVGSMILAnimationInImageRegardlessOfCache: 925 case SVGSMILAnimationInImageRegardlessOfCache:
926 return "SVG's SMIL animations (<animate>, <set>, etc.) are deprecated an d will be removed. Please use CSS animations or Web animations instead."; 926 return "SVG's SMIL animations (<animate>, <set>, etc.) are deprecated an d will be removed. Please use CSS animations or Web animations instead.";
927
927 case PrefixedPerformanceClearResourceTimings: 928 case PrefixedPerformanceClearResourceTimings:
928 return replacedBy("Performance.webkitClearResourceTimings", "Performance .clearResourceTimings"); 929 return replacedBy("Performance.webkitClearResourceTimings", "Performance .clearResourceTimings");
929 930
930 case PrefixedPerformanceSetResourceTimingBufferSize: 931 case PrefixedPerformanceSetResourceTimingBufferSize:
931 return replacedBy("Performance.webkitSetResourceTimingBufferSize", "Perf ormance.setResourceTimingBufferSize"); 932 return replacedBy("Performance.webkitSetResourceTimingBufferSize", "Perf ormance.setResourceTimingBufferSize");
932 933
933 case PrefixedPerformanceResourceTimingBufferFull: 934 case PrefixedPerformanceResourceTimingBufferFull:
934 return replacedBy("Performance.onwebkitresourcetimingbufferfull", "Perfo rmance.onresourcetimingbufferfull"); 935 return replacedBy("Performance.onwebkitresourcetimingbufferfull", "Perfo rmance.onresourcetimingbufferfull");
935 936
936 case FetchAPIRequestContext: 937 case FetchAPIRequestContext:
937 return "Request.context is deprecated and will be removed in M46 (see: h ttps://www.chromestatus.com/feature/5534702526005248)."; 938 return "Request.context is deprecated and will be removed in M46 (see: h ttps://www.chromestatus.com/feature/5534702526005248).";
938 939
939 case HeaderValueNotMatchingRFC7230: 940 case HeaderValueNotMatchingRFC7230:
940 return "Header values not matching to RFC 7230, will be deprecated (see: https://www.chromestatus.com/feature/6457425448140800)."; 941 return "Header values not matching to RFC 7230, will be deprecated (see: https://www.chromestatus.com/feature/6457425448140800).";
941 942
942 case BluetoothDeviceInstanceId: 943 case BluetoothDeviceInstanceId:
943 return replacedBy("BluetoothDevice.instanceID", "BluetoothDevice.id"); 944 return replacedBy("BluetoothDevice.instanceID", "BluetoothDevice.id");
944 945
946 case V8SVGElement_OffsetParent_AttributeGetter:
947 return "'SVGElement.offsetParent' is deprecated and will be removed in M 50, around April 2016. See https://www.chromestatus.com/features/572491246757478 4 for more details.";
948
949 case V8SVGElement_OffsetTop_AttributeGetter:
950 return "'SVGElement.offsetTop' is deprecated and will be removed in M50, around April 2016. See https://www.chromestatus.com/features/5724912467574784 f or more details.";
951
952 case V8SVGElement_OffsetLeft_AttributeGetter:
953 return "'SVGElement.offsetLeft' is deprecated and will be removed in M50 , around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details.";
954
955 case V8SVGElement_OffsetWidth_AttributeGetter:
956 return "'SVGElement.offsetWidth' is deprecated and will be removed in M5 0, around April 2016. See https://www.chromestatus.com/features/5724912467574784 for more details.";
957
958 case V8SVGElement_OffsetHeight_AttributeGetter:
959 return "'SVGElement.offsetHeight' is deprecated and will be removed in M 50, around April 2016. See https://www.chromestatus.com/features/572491246757478 4 for more details.";
960
945 // Features that aren't deprecated don't have a deprecation message. 961 // Features that aren't deprecated don't have a deprecation message.
946 default: 962 default:
947 return String(); 963 return String();
948 } 964 }
949 } 965 }
950 966
951 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 967 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
952 { 968 {
953 ASSERT(feature >= firstCSSProperty); 969 ASSERT(feature >= firstCSSProperty);
954 ASSERT(feature <= lastUnresolvedCSSProperty); 970 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
982 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 998 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
983 { 999 {
984 // FIXME: We may want to handle stylesheets that have multiple owners 1000 // FIXME: We may want to handle stylesheets that have multiple owners
985 // https://crbug.com/242125 1001 // https://crbug.com/242125
986 if (sheetContents && sheetContents->hasSingleOwnerNode()) 1002 if (sheetContents && sheetContents->hasSingleOwnerNode())
987 return getFrom(sheetContents->singleOwnerDocument()); 1003 return getFrom(sheetContents->singleOwnerDocument());
988 return 0; 1004 return 0;
989 } 1005 }
990 1006
991 } // namespace blink 1007 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698