[Oilpan] Fix wrong usage of HeapCountedSet<EventTarget*>

Fix wrong usage of HeapCountedSet<EventTarget*>

BUG=515524
Committed: https://crrev.com/0ab9a39b2347bc686cb6c2a7464acfebe3d4bd10
Cr-Commit-Position: refs/heads/master@{#353714}

[peria, 2015-10-11 14:52:21]

Patchset #1 (id:1) has been deleted

[peria, 2015-10-13 00:08:51]

peria@chromium.org changed reviewers:
+ haraken@chromium.org, oilpan-reviews@chromium.org

[peria, 2015-10-13 00:08:52]

PTL

[haraken, 2015-10-13 01:18:01]

https://codereview.chromium.org/1401033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/EventHandlerRegistry.h (right):

https://codereview.chromium.org/1401033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/EventHandlerRegistry.h:17: using
EventTargetSet = WillBeHeapHashCountedSet<RawPtrWillBeMember<EventTarget>>;

I'd prefer using  WillBeHeapHashCountedSet<RawPtrWillBeWeakMember<EventTarget>>,
because the weak processing is manually done by
EventHandlerRegistry::clearWeakMembers(). (Technically it doesn't matter whether
we use Member or WeakMember because the weak processing is manually done
anyway.)

[peria, 2015-10-13 06:57:19]

https://codereview.chromium.org/1401033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/EventHandlerRegistry.h (right):

https://codereview.chromium.org/1401033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/EventHandlerRegistry.h:17: using
EventTargetSet = WillBeHeapHashCountedSet<RawPtrWillBeMember<EventTarget>>;
On 2015/10/13 01:18:01, haraken wrote:
> 
> I'd prefer using 
WillBeHeapHashCountedSet<RawPtrWillBeWeakMember<EventTarget>>,
> because the weak processing is manually done by
> EventHandlerRegistry::clearWeakMembers(). (Technically it doesn't matter
whether
> we use Member or WeakMember because the weak processing is manually done
> anyway.)

Done.

[haraken, 2015-10-13 07:10:45]

LGTM

https://codereview.chromium.org/1401033002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/EventHandlerRegistry.h (right):

https://codereview.chromium.org/1401033002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/EventHandlerRegistry.h:17: using
EventTargetSet = WillBeHeapHashCountedSet<RawPtrWillBeWeakMember<EventTarget>>;

Let's add a comment that the weak processing is handled manually by
clearWeakMembers.

[peria, 2015-10-13 08:31:42]

Patchset #3 (id:60001) has been deleted

[peria, 2015-10-13 08:32:12]

https://codereview.chromium.org/1401033002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/EventHandlerRegistry.h (right):

https://codereview.chromium.org/1401033002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/EventHandlerRegistry.h:17: using
EventTargetSet = WillBeHeapHashCountedSet<RawPtrWillBeWeakMember<EventTarget>>;
On 2015/10/13 07:10:45, haraken wrote:
> 
> Let's add a comment that the weak processing is handled manually by
> clearWeakMembers.

Done.

[peria, 2015-10-13 09:14:24]

The CQ bit was checked by peria@chromium.org

[peria, 2015-10-13 09:14:25]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/1401033002/#ps80001
(title: "Add a comment")

[commit-bot: I haz the power, 2015-10-13 09:14:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1401033002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1401033002/80001

[commit-bot: I haz the power, 2015-10-13 10:21:40]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2015-10-13 10:22:29]

Patchset 3 (id:??) landed as
https://crrev.com/0ab9a39b2347bc686cb6c2a7464acfebe3d4bd10
Cr-Commit-Position: refs/heads/master@{#353714}

[sof, 2015-10-13 15:21:19]

A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/1405513003/ by sigbjornf@opera.com.

The reason for reverting is: Broke a number of tests on all Oilpan bots,


http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan/...

Lazy sweeping of EventTargetSet related..