Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Side by Side Diff: third_party/WebKit/Source/core/frame/EventHandlerRegistry.h

Issue 1401033002: [Oilpan] Fix wrong usage of HeapCountedSet<EventTarget*> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use WeakMember Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EventHandlerRegistry_h 5 #ifndef EventHandlerRegistry_h
6 #define EventHandlerRegistry_h 6 #define EventHandlerRegistry_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/frame/FrameHost.h" 9 #include "core/frame/FrameHost.h"
10 #include "wtf/HashCountedSet.h" 10 #include "wtf/HashCountedSet.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class Document; 14 class Document;
15 class EventTarget; 15 class EventTarget;
16 16
17 typedef HashCountedSet<EventTarget*> EventTargetSet; 17 using EventTargetSet = WillBeHeapHashCountedSet<RawPtrWillBeWeakMember<EventTarg et>>;
haraken 2015/10/13 07:10:45 Let's add a comment that the weak processing is ha
peria 2015/10/13 08:32:12 Done.
18 18
19 // Registry for keeping track of event handlers. Note that only handlers on 19 // Registry for keeping track of event handlers. Note that only handlers on
20 // documents that can be rendered or can receive input (i.e., are attached to a 20 // documents that can be rendered or can receive input (i.e., are attached to a
21 // FrameHost) are registered here. 21 // FrameHost) are registered here.
22 class CORE_EXPORT EventHandlerRegistry final : public NoBaseWillBeGarbageCollect edFinalized<EventHandlerRegistry> { 22 class CORE_EXPORT EventHandlerRegistry final : public NoBaseWillBeGarbageCollect edFinalized<EventHandlerRegistry> {
23 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(EventHandlerRegistry); 23 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(EventHandlerRegistry);
24 public: 24 public:
25 explicit EventHandlerRegistry(FrameHost&); 25 explicit EventHandlerRegistry(FrameHost&);
26 virtual ~EventHandlerRegistry(); 26 virtual ~EventHandlerRegistry();
27 27
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 99
100 void checkConsistency() const; 100 void checkConsistency() const;
101 101
102 RawPtrWillBeMember<FrameHost> m_frameHost; 102 RawPtrWillBeMember<FrameHost> m_frameHost;
103 EventTargetSet m_targets[EventHandlerClassCount]; 103 EventTargetSet m_targets[EventHandlerClassCount];
104 }; 104 };
105 105
106 } // namespace blink 106 } // namespace blink
107 107
108 #endif // EventHandlerRegistry_h 108 #endif // EventHandlerRegistry_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698