Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/core/frame/EventHandlerRegistry.h

Issue 1401033002: [Oilpan] Fix wrong usage of HeapCountedSet<EventTarget*> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
diff --git a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
index b89ea927a4ad5d8ce3a45e8d2d4b52ba1ac6686d..c517b617322d8c24b0a331b417743455c3d10100 100644
--- a/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
+++ b/third_party/WebKit/Source/core/frame/EventHandlerRegistry.h
@@ -14,7 +14,10 @@ namespace blink {
class Document;
class EventTarget;
-typedef HashCountedSet<EventTarget*> EventTargetSet;
+// EventHandlerRegistry::m_targets is handled manually in clearWeakMembers(),
+// so its type can be HeapHashCountedSet<Member<>>, but we use WeakMember<> in this
+// alias for future other use cases.
+using EventTargetSet = WillBeHeapHashCountedSet<RawPtrWillBeWeakMember<EventTarget>>;
// Registry for keeping track of event handlers. Note that only handlers on
// documents that can be rendered or can receive input (i.e., are attached to a
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698