Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: third_party/WebKit/Source/core/frame/EventHandlerRegistry.h

Issue 1401033002: [Oilpan] Fix wrong usage of HeapCountedSet<EventTarget*> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add a comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EventHandlerRegistry_h 5 #ifndef EventHandlerRegistry_h
6 #define EventHandlerRegistry_h 6 #define EventHandlerRegistry_h
7 7
8 #include "core/CoreExport.h" 8 #include "core/CoreExport.h"
9 #include "core/frame/FrameHost.h" 9 #include "core/frame/FrameHost.h"
10 #include "wtf/HashCountedSet.h" 10 #include "wtf/HashCountedSet.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 class Document; 14 class Document;
15 class EventTarget; 15 class EventTarget;
16 16
17 typedef HashCountedSet<EventTarget*> EventTargetSet; 17 // EventHandlerRegistry::m_targets is handled manually in clearWeakMembers(),
18 // so its type can be HeapHashCountedSet<Member<>>, but we use WeakMember<> in t his
19 // alias for future other use cases.
20 using EventTargetSet = WillBeHeapHashCountedSet<RawPtrWillBeWeakMember<EventTarg et>>;
18 21
19 // Registry for keeping track of event handlers. Note that only handlers on 22 // Registry for keeping track of event handlers. Note that only handlers on
20 // documents that can be rendered or can receive input (i.e., are attached to a 23 // documents that can be rendered or can receive input (i.e., are attached to a
21 // FrameHost) are registered here. 24 // FrameHost) are registered here.
22 class CORE_EXPORT EventHandlerRegistry final : public NoBaseWillBeGarbageCollect edFinalized<EventHandlerRegistry> { 25 class CORE_EXPORT EventHandlerRegistry final : public NoBaseWillBeGarbageCollect edFinalized<EventHandlerRegistry> {
23 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(EventHandlerRegistry); 26 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(EventHandlerRegistry);
24 public: 27 public:
25 explicit EventHandlerRegistry(FrameHost&); 28 explicit EventHandlerRegistry(FrameHost&);
26 virtual ~EventHandlerRegistry(); 29 virtual ~EventHandlerRegistry();
27 30
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 102
100 void checkConsistency() const; 103 void checkConsistency() const;
101 104
102 RawPtrWillBeMember<FrameHost> m_frameHost; 105 RawPtrWillBeMember<FrameHost> m_frameHost;
103 EventTargetSet m_targets[EventHandlerClassCount]; 106 EventTargetSet m_targets[EventHandlerClassCount];
104 }; 107 };
105 108
106 } // namespace blink 109 } // namespace blink
107 110
108 #endif // EventHandlerRegistry_h 111 #endif // EventHandlerRegistry_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698