Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1399853005: Changed CSSColorValue to return a Color (Closed)

Created:
5 years, 2 months ago by sashab
Modified:
5 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, krit, eae+blinkwatch, Eric Willigers, f(malita), fs, gyuyoung2, Justin Novosad, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@split_color
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed CSSColorValue to return a Color Changed CSSColorValue to return a Color, instead of an RGBA32. BUG=523893 Committed: https://crrev.com/b03e12a95f921947fe1f7234527a0135912c7427 Cr-Commit-Position: refs/heads/master@{#357715}

Patch Set 1 #

Patch Set 2 : Fix for ManifestParser #

Total comments: 1

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -67 lines) Patch
M third_party/WebKit/Source/core/css/CSSColorValue.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.cpp View 4 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/TextLinkColors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 2 10 chunks +24 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBodyElement.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedColor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasGradient.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 2 3 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebCSSParser.cpp View 1 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 45 (21 generated)
sashab
5 years, 2 months ago (2015-10-15 01:50:58 UTC) #2
Timothy Loh
On 2015/10/15 01:50:58, sashab wrote: ok lgtm
5 years, 2 months ago (2015-10-19 02:56:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399853005/1
5 years, 2 months ago (2015-10-19 05:10:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/110446)
5 years, 2 months ago (2015-10-19 05:17:06 UTC) #7
sashab
aelias: Please review changes in third_party/WebKit/Source/web senorblanco: Please review changes in third_party/WebKit/Source/modules/canvas2d This is a ...
5 years, 2 months ago (2015-10-19 05:19:56 UTC) #9
aelias_OOO_until_Jul13
Source/web lgtm
5 years, 2 months ago (2015-10-19 06:16:53 UTC) #10
Stephen White
Source/modules/canvas2d LGTM +junov FYI
5 years, 2 months ago (2015-10-19 17:27:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399853005/1
5 years, 2 months ago (2015-10-19 23:52:29 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/68582)
5 years, 2 months ago (2015-10-20 00:17:57 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399853005/1
5 years, 2 months ago (2015-10-20 00:25:15 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/67318)
5 years, 2 months ago (2015-10-20 00:35:30 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399853005/1
5 years, 2 months ago (2015-10-20 23:35:21 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/69219)
5 years, 2 months ago (2015-10-21 00:02:03 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399853005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399853005/1
5 years, 2 months ago (2015-10-21 04:24:34 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/69299)
5 years, 2 months ago (2015-10-21 04:46:12 UTC) #29
sashab
+aelias@chromium.org https://codereview.chromium.org/1399853005/diff/20001/third_party/WebKit/Source/web/WebCSSParser.cpp File third_party/WebKit/Source/web/WebCSSParser.cpp (right): https://codereview.chromium.org/1399853005/diff/20001/third_party/WebKit/Source/web/WebCSSParser.cpp#newcode18 third_party/WebKit/Source/web/WebCSSParser.cpp:18: return success; +aelias ptal... Can't think of a ...
5 years, 2 months ago (2015-10-21 05:41:52 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399853005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399853005/20001
5 years, 2 months ago (2015-10-21 05:42:29 UTC) #32
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-21 08:52:24 UTC) #34
aelias_OOO_until_Jul13
OK, still lgtm.
5 years, 2 months ago (2015-10-21 21:48:49 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399853005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399853005/20001
5 years, 2 months ago (2015-10-22 06:55:30 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/113376) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-22 06:57:10 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1399853005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1399853005/60001
5 years, 1 month ago (2015-11-03 22:40:51 UTC) #43
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 1 month ago (2015-11-04 01:42:53 UTC) #44
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 01:44:32 UTC) #45
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b03e12a95f921947fe1f7234527a0135912c7427
Cr-Commit-Position: refs/heads/master@{#357715}

Powered by Google App Engine
This is Rietveld 408576698