third_party/WebKit/Source/core/css/CSSColorValue.h - Issue 1399853005: Changed CSSColorValue to return a Color

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSColorValue.h

Issue 1399853005: Changed CSSColorValue to return a Color (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_color

Patch Set: Rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/CSSColorValue.h

diff --git a/third_party/WebKit/Source/core/css/CSSColorValue.h b/third_party/WebKit/Source/core/css/CSSColorValue.h

index e8e532f0735da52edc1c3712714ea4e6ef565912..6b7ce222f668cb349965cc1d15c5c57c81a06680 100644

--- a/third_party/WebKit/Source/core/css/CSSColorValue.h

+++ b/third_party/WebKit/Source/core/css/CSSColorValue.h

@@ -24,8 +24,7 @@ public:

return m_color.serializedAsCSSComponentValue();

}

- // TODO(sashab): Make this return a Color.

- RGBA32 value() const { return m_color.rgb(); }

+ Color value() const { return m_color; }

bool equals(const CSSColorValue& other) const

{

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/parser/CSSParser.h » ('j') | no next file with comments »