Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp

Issue 1399853005: Changed CSSColorValue to return a Color (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_color
Patch Set: Rebase Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebCSSParser.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp
diff --git a/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp b/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp
index 4b2636f7d8e5351f5ced9ced7757b18b093e9505..89652816037fa3f95ae848c98ad0a63c9e6a5940 100644
--- a/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp
+++ b/third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp
@@ -29,11 +29,11 @@ void SimDisplayItemList::appendDrawingItem(const WebRect&, const SkPicture* pict
bool SimDisplayItemList::contains(SimCanvas::CommandType type, const String& colorString) const
{
- RGBA32 color = 0;
+ Color color = 0;
if (!colorString.isNull())
RELEASE_ASSERT(CSSParser::parseColor(color, colorString, true));
for (auto& command : m_commands) {
- if (command.type == type && (colorString.isNull() || command.color == color))
+ if (command.type == type && (colorString.isNull() || command.color == color.rgb()))
return true;
}
return false;
« no previous file with comments | « third_party/WebKit/Source/web/WebCSSParser.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698