third_party/WebKit/Source/web/WebCSSParser.cpp - Issue 1399853005: Changed CSSColorValue to return a Color

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebCSSParser.cpp

Issue 1399853005: Changed CSSColorValue to return a Color (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_color

Patch Set: Rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebCSSParser.cpp

diff --git a/third_party/WebKit/Source/web/WebCSSParser.cpp b/third_party/WebKit/Source/web/WebCSSParser.cpp

index ae13da3cb1e9b376d217d884c2eef63c6caefec6..39b5e8160b0ca8681d90d51f7f641b3197f8970c 100644

--- a/third_party/WebKit/Source/web/WebCSSParser.cpp

+++ b/third_party/WebKit/Source/web/WebCSSParser.cpp

@@ -10,9 +10,12 @@

namespace blink {

-bool WebCSSParser::parseColor(WebColor* color, const WebString& colorString)

+bool WebCSSParser::parseColor(WebColor* webColor, const WebString& colorString)

{

- return CSSParser::parseColor(*color, colorString, true);

+ Color color = Color(*webColor);

+ bool success = CSSParser::parseColor(color, colorString, true);

+ *webColor = color.rgb();

+ return success;

}

} // namespace blink