third_party/WebKit/Source/core/css/parser/CSSParser.h - Issue 1399853005: Changed CSSColorValue to return a Color

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParser.h

Issue 1399853005: Changed CSSColorValue to return a Color (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_color

Patch Set: Rebase Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/css/parser/CSSParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParser.h b/third_party/WebKit/Source/core/css/parser/CSSParser.h

index 53b050903acef0a4e5fed606be10a9b0c117299e..0c5bc6ec5502444f7ac88c62cf3374ed9bd1bad4 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSParser.h

@@ -49,8 +49,8 @@ public:

// The color will only be changed when string contains a valid CSS color, so callers

// can set it to a default color and ignore the boolean result.

- static bool parseColor(RGBA32& color, const String&, bool strict = false);

- static bool parseSystemColor(RGBA32& color, const String&);

+ static bool parseColor(Color&, const String&, bool strict = false);

+ static bool parseSystemColor(Color&, const String&);

static void parseSheetForInspector(const CSSParserContext&, StyleSheetContents*, const String&, CSSParserObserver&);

static void parseDeclarationListForInspector(const CSSParserContext&, const String&, CSSParserObserver&);