Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 139983009: ui::LocatedEvent location() returns gfx::PointF (Closed)

Created:
6 years, 10 months ago by tdresser
Modified:
6 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, asanka, sadrul, yusukes+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, ben+aura_chromium.org, benjhayden+dwatch_chromium.org, Ilya Sherman, ozone-reviews_chromium.org, aboxhall+watch_chromium.org, jam, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, rjkroege, jennb, dyu1, penghuang+watch_chromium.org, jianli, yuzo+watch_chromium.org, ben+corewm_chromium.org, ben+views_chromium.org, rouslan+autofillwatch_chromium.org, chrome-apps-syd-reviews_chromium.org, plundblad+watch_chromium.org, tfarina, Dmitry Titov, benquan, Dane Wallinga, dtseng+watch_chromium.org, estade+watch_chromium.org, James Su, ben+ash_chromium.org, tdanderson
Visibility:
Public.

Description

ui::LocatedEvent bounds() returns gfx::PointF (WIP). Closed based on discussion in: https://codereview.chromium.org/265713007/ This is a largely automated change. I'm hoping I can find a better approach than this, but this may be a reasonable first step. Automated portions of the patch are performed by the script located here: http://pastebin.com/raw.php?i=jj3ZKbd3 BUG=337824

Patch Set 1 : Automated Changes #

Patch Set 2 : Manual Changes #

Patch Set 3 : Rebase - automated changes only #

Patch Set 4 : Rebase - manual changes only #

Patch Set 5 : Fix test. #

Patch Set 6 : Rebase. #

Patch Set 7 : Undo accidental change. #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -327 lines) Patch
M ash/autoclick/autoclick_unittest.cc View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M ash/display/event_transformation_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 1 2 4 chunks +8 lines, -5 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker_unittest.cc View 1 2 3 4 chunks +8 lines, -8 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/alternate_frame_size_button.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M ash/frame/caption_buttons/bubble_contents_button_row.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_caption_button.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ash/frame/caption_buttons/frame_maximize_button.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M ash/host/ash_window_tree_host_x11_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/ime/candidate_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/overflow_bubble.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_bezel_event_filter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ash/sticky_keys/sticky_keys_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/tray/actionable_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ash/touch/touch_uma.cc View 1 2 3 4 5 3 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/overview_gesture_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_overview.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_window_event_handler.cc View 1 2 2 chunks +6 lines, -8 lines 0 comments Download
M ash/wm/partial_screenshot_view.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/resize_handle_window_targeter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 2 5 chunks +8 lines, -6 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 1 2 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_base_view.cc View 1 2 4 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/ui/views/content_setting_bubble_contents.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_root_view.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/bubble_icon_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/content_setting_image_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_decoration_view.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/open_pdf_in_reader_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/origin_chip_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/location_bar/page_action_image_view.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/page_info_helper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/panels/panel_frame_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 1 2 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_button.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_origin_chip_view.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M ui/app_list/views/apps_grid_view.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/window_event_dispatcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M ui/aura/window_targeter.cc View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event.h View 1 2 3 4 5 1 chunk +1 line, -4 lines 4 comments Download
M ui/events/event_processor_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/events/gestures/gesture_point.cc View 1 2 4 chunks +12 lines, -12 lines 0 comments Download
M ui/events/gestures/gesture_sequence.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/events/ozone/evdev/event_factory_evdev.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/events/ozone/events_ozone.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/custom_button.cc View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M ui/views/controls/link.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 2 3 4 5 16 chunks +20 lines, -19 lines 0 comments Download
M ui/views/controls/menu/menu_host_root_view.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar_thumb.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/controls/single_split_view.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/controls/slider.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M ui/views/controls/tabbed_pane/tabbed_pane.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 2 3 4 5 12 chunks +30 lines, -20 lines 0 comments Download
M ui/views/controls/textfield/textfield_unittest.cc View 1 2 3 chunks +14 lines, -11 lines 0 comments Download
M ui/views/controls/tree/tree_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/view.cc View 1 2 9 chunks +21 lines, -13 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 2 chunks +11 lines, -6 lines 0 comments Download
M ui/views/widget/root_view.cc View 1 2 6 chunks +14 lines, -9 lines 0 comments Download
M ui/views/widget/widget.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M ui/wm/core/compound_event_filter.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M ui/wm/core/easy_resize_window_targeter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/masked_window_targeter.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tdresser
Sadrul, do you think this is a decent approach? If so, can you take a ...
6 years, 7 months ago (2014-05-01 14:21:02 UTC) #1
sadrul
Thanks! I was hoping we would take this opportunity to clean up some of the ...
6 years, 7 months ago (2014-05-02 06:47:18 UTC) #2
tdresser
6 years, 7 months ago (2014-05-02 13:46:39 UTC) #3
I think it makes sense to perform the API cleanup in a separate set of patches.

This CL is pretty much risk-free, and won't require any modifications to tests.

The API modification will require updating tests, and will be a LOT of code.

Didn't we decide that we were going to split up the API cleanup work? I don't
have much time to invest in it.

https://codereview.chromium.org/139983009/diff/680001/ui/events/event.h
File ui/events/event.h (right):

https://codereview.chromium.org/139983009/diff/680001/ui/events/event.h#newco...
ui/events/event.h:251: gfx::Point root_location() const {
On 2014/05/02 06:47:18, sadrul wrote:
> We can make this PointF too?

Do you think it makes sense to do that in the same patch?

https://codereview.chromium.org/139983009/diff/680001/ui/events/event.h#newco...
ui/events/event.h:264: // crbug.com/337824.
On 2014/05/02 06:47:18, sadrul wrote:
> Can we remove this?

I don't think we can remove this yet. 

In a followup patch we should add a ConvertPointFToTarget method, which would
let us clean this up.

Powered by Google App Engine
This is Rietveld 408576698