chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc - Issue 139983009: ui::LocatedEvent location() returns gfx::PointF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

Issue 139983009: ui::LocatedEvent location() returns gfx::PointF (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Undo accidental change. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

index 23a59502132629dee7cff272b220ae78cd404997..1d3e4a81b8877573250986eb8ce6ac93d24d859a 100644

--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

@@ -79,7 +79,8 @@ bool ManagePasswordsIconView::OnMousePressed(const ui::MouseEvent& event) {

}

void ManagePasswordsIconView::OnMouseReleased(const ui::MouseEvent& event) {

- if (event.IsOnlyLeftMouseButton() && HitTestPoint(event.location())) {

+ if (event.IsOnlyLeftMouseButton() &&

+ HitTestPoint(gfx::ToFlooredPoint(event.location()))) {

ManagePasswordsBubbleView::ShowBubble(

location_bar_delegate_->GetWebContents(),

ManagePasswordsBubbleView::USER_ACTION);