chrome/browser/ui/views/toolbar/toolbar_origin_chip_view.cc - Issue 139983009: ui::LocatedEvent location() returns gfx::PointF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_origin_chip_view.cc

Issue 139983009: ui::LocatedEvent location() returns gfx::PointF (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Undo accidental change. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/toolbar/toolbar_origin_chip_view.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_origin_chip_view.cc b/chrome/browser/ui/views/toolbar/toolbar_origin_chip_view.cc

index 4c625381205545b29d37154c63e5554a861b2410..d1fa8ade0d4c8d479b0a14ca3c4df3357b8df1d0 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_origin_chip_view.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_origin_chip_view.cc

@@ -330,8 +330,8 @@ void ToolbarOriginChipView::ButtonPressed(views::Button* sender,

location_icon_view_->set_interactive(true);

const ui::LocatedEvent& located_event =

static_cast<const ui::LocatedEvent&>(event);

- if (GetEventHandlerForPoint(located_event.location()) ==

- location_icon_view_) {

+ if (GetEventHandlerForPoint(gfx::ToFlooredPoint(

+ located_event.location())) == location_icon_view_) {

location_icon_view_->page_info_helper()->ProcessEvent(located_event);

location_icon_view_->set_interactive(false);

return;