chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 139983009: ui::LocatedEvent location() returns gfx::PointF

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 139983009: ui::LocatedEvent location() returns gfx::PointF (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Undo accidental change. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index f681a9909b5c7de5775235aaeb7ddbe68cb082da..e4d5869fd92480b4aa999abbba8dd093ffbf4d88 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -676,7 +676,8 @@ bool OmniboxViewViews::OnMousePressed(const ui::MouseEvent& event) {

}

bool OmniboxViewViews::OnMouseDragged(const ui::MouseEvent& event) {

- if (ExceededDragThreshold(event.location() - last_click_location()))

+ if (ExceededDragThreshold(gfx::ToFlooredPoint(event.location()) -

+ last_click_location()))

select_all_on_mouse_release_ = false;

return views::Textfield::OnMouseDragged(event);

}