Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398973003: Don't use base::MessageLoop::{Quit,QuitClosure} in net/ (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use base::MessageLoop::{Quit,QuitClosure} in net/ This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 TEST= R=eroman@chromium.org Committed: https://crrev.com/375812eee1507aa8b8aac6ad9e4bf61365ab74d8 Cr-Commit-Position: refs/heads/master@{#353372}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -49 lines) Patch
M net/android/network_change_notifier_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/file_stream_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/network_change_notifier_win_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_store_test_callbacks.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cookies/cookie_store_unittest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/dns_config_service_posix_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_config_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/dns_transaction_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/dns/host_resolver_impl_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M net/dns/mdns_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_body_drainer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_server_properties_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_transaction_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/mock_proxy_script_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/socket/client_socket_pool_base_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/gdig/gdig.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/get_server_time/get_server_time.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/synchronous_host_resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_test_util.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
ki.stfu
5 years, 2 months ago (2015-10-09 19:10:22 UTC) #1
eroman
patchset#1 LGTM
5 years, 2 months ago (2015-10-09 19:27:21 UTC) #2
ki.stfu
On 2015/10/09 19:27:21, eroman wrote: > patchset#1 LGTM Thanks for quick response.
5 years, 2 months ago (2015-10-09 20:11:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398973003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398973003/1
5 years, 2 months ago (2015-10-09 20:12:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-09 20:23:33 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-09 20:24:43 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/375812eee1507aa8b8aac6ad9e4bf61365ab74d8
Cr-Commit-Position: refs/heads/master@{#353372}

Powered by Google App Engine
This is Rietveld 408576698