Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: net/base/network_change_notifier_win_unittest.cc

Issue 1398973003: Don't use base::MessageLoop::{Quit,QuitClosure} in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/file_stream_unittest.cc ('k') | net/cookies/cookie_monster_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/network_change_notifier_win_unittest.cc
diff --git a/net/base/network_change_notifier_win_unittest.cc b/net/base/network_change_notifier_win_unittest.cc
index 04b19e6e6d2b5debdd7169029d5f754d054fdbcb..14bf01aae1b63a19e2e63cf0d3103366c402ff2d 100644
--- a/net/base/network_change_notifier_win_unittest.cc
+++ b/net/base/network_change_notifier_win_unittest.cc
@@ -60,7 +60,7 @@ class TestIPAddressObserver : public NetworkChangeNotifier::IPAddressObserver {
};
bool ExitMessageLoopAndReturnFalse() {
- base::MessageLoop::current()->Quit();
+ base::MessageLoop::current()->QuitWhenIdle();
return false;
}
@@ -164,9 +164,10 @@ class NetworkChangeNotifierWinTest : public testing::Test {
EXPECT_FALSE(network_change_notifier_.is_watching());
EXPECT_LT(0, network_change_notifier_.sequential_failures());
- EXPECT_CALL(test_ip_address_observer_, OnIPAddressChanged()).Times(1)
- .WillOnce(
- Invoke(base::MessageLoop::current(), &base::MessageLoop::Quit));
+ EXPECT_CALL(test_ip_address_observer_, OnIPAddressChanged())
+ .Times(1)
+ .WillOnce(Invoke(base::MessageLoop::current(),
+ &base::MessageLoop::QuitWhenIdle));
EXPECT_CALL(network_change_notifier_, WatchForAddressChangeInternal())
.Times(1).WillOnce(Return(true));
« no previous file with comments | « net/base/file_stream_unittest.cc ('k') | net/cookies/cookie_monster_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698