net/cookies/cookie_store_test_callbacks.cc - Issue 1398973003: Don't use base::MessageLoop::{Quit,QuitClosure} in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/cookie_store_test_callbacks.cc

Issue 1398973003: Don't use base::MessageLoop::{Quit,QuitClosure} in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/cookies/cookie_store_test_callbacks.cc

diff --git a/net/cookies/cookie_store_test_callbacks.cc b/net/cookies/cookie_store_test_callbacks.cc

index afb05d1514642912a41697d9a7498690709d8f3c..491fe0e8bf94ac1a0e7f15843f6e200ba48d081d 100644

--- a/net/cookies/cookie_store_test_callbacks.cc

+++ b/net/cookies/cookie_store_test_callbacks.cc

@@ -38,8 +38,8 @@ void CookieCallback::CallbackEpilogue() {

did_run_ = true;

EXPECT_EQ(expected_loop, base::MessageLoop::current());

- loop_to_quit_->task_runner()->PostTask(FROM_HERE,

- base::MessageLoop::QuitClosure());

+ loop_to_quit_->task_runner()->PostTask(

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

}

StringResultCookieCallback::StringResultCookieCallback() {}

« no previous file with comments | « net/cookies/cookie_monster_unittest.cc ('k') | net/cookies/cookie_store_unittest.h » ('j') | no next file with comments »