net/http/http_server_properties_manager_unittest.cc - Issue 1398973003: Don't use base::MessageLoop::{Quit,QuitClosure} in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_server_properties_manager_unittest.cc

Issue 1398973003: Don't use base::MessageLoop::{Quit,QuitClosure} in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_server_properties_manager_unittest.cc

diff --git a/net/http/http_server_properties_manager_unittest.cc b/net/http/http_server_properties_manager_unittest.cc

index 40b6211c0554584b669607e82981cb5a8ee7d21c..cf32d38450fbd27442895e29e1527f9f30db1fde 100644

--- a/net/http/http_server_properties_manager_unittest.cc

+++ b/net/http/http_server_properties_manager_unittest.cc

@@ -823,7 +823,7 @@ TEST_F(HttpServerPropertiesManagerTest, Clear) {

ExpectPrefsUpdate();

// Clear http server data, time out if we do not get a completion callback.

- http_server_props_manager_->Clear(base::MessageLoop::QuitClosure());

+ http_server_props_manager_->Clear(base::MessageLoop::QuitWhenIdleClosure());

base::RunLoop().Run();

EXPECT_FALSE(

« no previous file with comments | « net/http/http_response_body_drainer_unittest.cc ('k') | net/http/http_stream_factory_impl_unittest.cc » ('j') | no next file with comments »