net/proxy/proxy_resolver_v8_tracing_unittest.cc - Issue 1398973003: Don't use base::MessageLoop::{Quit,QuitClosure} in net/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/proxy/proxy_resolver_v8_tracing_unittest.cc

Issue 1398973003: Don't use base::MessageLoop::{Quit,QuitClosure} in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/proxy/proxy_resolver_v8_tracing_unittest.cc

diff --git a/net/proxy/proxy_resolver_v8_tracing_unittest.cc b/net/proxy/proxy_resolver_v8_tracing_unittest.cc

index 3bec37031d854a956531c174af35bcc857d7bead..fbca99f225f792e75e662510b5d23b585da1ca6e 100644

--- a/net/proxy/proxy_resolver_v8_tracing_unittest.cc

+++ b/net/proxy/proxy_resolver_v8_tracing_unittest.cc

@@ -688,7 +688,7 @@ class BlockableHostResolver : public HostResolver {

// Indicate to the caller that a request was received.

EXPECT_TRUE(waiting_for_resolve_);

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

// This line is intentionally after action_.Run(), since one of the

// tests does a cancellation inside of Resolve(), and it is more

« no previous file with comments | « net/proxy/mock_proxy_script_fetcher.cc ('k') | net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc » ('j') | no next file with comments »