Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1398153002: Don't use base::MessageLoop::{Quit,QuitClosure} in content/ (Closed)

Created:
5 years, 2 months ago by ki.stfu
Modified:
5 years, 2 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, asanka, yusukes+watch_chromium.org, tzik, posciak+watch_chromium.org, mlamouri+watch-sensors_chromium.org, dcheng, sievers+watch_chromium.org, rginda+watch_chromium.org, jdduke+watch_chromium.org, miu+watch_chromium.org, wjmaclean, mlamouri+watch-geolocation_chromium.org, ben+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, kalyank, mlamouri+watch-content_chromium.org, yzshen+watch_chromium.org, qsr+mojo_chromium.org, nhiroki, feature-media-reviews_chromium.org, timvolodine, Michael van Ouwerkerk, piman+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, darin (slow to review), jochen+watch_chromium.org, riju_, shuchen+watch_chromium.org, mcasas+watch_chromium.org, yurys, Aaron Boodman, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org, James Su, kinuko+fileapi, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't use base::MessageLoop::{Quit,QuitClosure} in content/ This patch renames base::MessageLoop::{Quit,QuitClosure} to base::MessageLoop::{QuitWhenIdle,QuitWhenIdleClosure}. BUG=131220 R=nick@chromium.org Committed: https://crrev.com/8007792478db51bdbfc4b26a6063d3b9ef8c0c3f Cr-Commit-Position: refs/heads/master@{#353616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -89 lines) Patch
M content/browser/browser_thread_unittest.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M content/browser/download/download_file_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/download/drag_download_file_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/download/mhtml_generation_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/file_system_operation_impl_write_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/local_file_stream_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/fileapi/mock_url_request_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/geolocation_provider_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/geolocation/network_location_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M content/browser/renderer_host/input/gesture_event_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/input/touch_event_queue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M content/browser/storage_partition_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/public/test/download_test_observer.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/public/test/javascript_test_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/test/test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/blink_test_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_browser_main.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_mojo_test_utils_android.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/appcache_test_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
ki.stfu
5 years, 2 months ago (2015-10-09 19:11:59 UTC) #1
ki.stfu
Friendly ping.
5 years, 2 months ago (2015-10-12 19:06:36 UTC) #3
ki.stfu
nick@: can you help with reviewing this CL?
5 years, 2 months ago (2015-10-12 20:25:06 UTC) #5
ncarter (slow)
lgtm
5 years, 2 months ago (2015-10-12 21:25:54 UTC) #6
ki.stfu
On 2015/10/12 21:25:54, ncarter wrote: > lgtm Thank you a lot!
5 years, 2 months ago (2015-10-12 21:29:16 UTC) #9
ki.stfu
On 2015/10/12 21:25:54, ncarter wrote: > lgtm Thank you a lot!
5 years, 2 months ago (2015-10-12 21:29:20 UTC) #10
ki.stfu
On 2015/10/12 21:25:54, ncarter wrote: > lgtm Thank you a lot!
5 years, 2 months ago (2015-10-12 21:29:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398153002/1
5 years, 2 months ago (2015-10-12 21:30:15 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-12 22:46:40 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 22:48:02 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8007792478db51bdbfc4b26a6063d3b9ef8c0c3f
Cr-Commit-Position: refs/heads/master@{#353616}

Powered by Google App Engine
This is Rietveld 408576698