content/browser/geolocation/geolocation_provider_impl_unittest.cc - Issue 1398153002: Don't use base::MessageLoop::{Quit,QuitClosure} in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/geolocation_provider_impl_unittest.cc

Issue 1398153002: Don't use base::MessageLoop::{Quit,QuitClosure} in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/fileapi/mock_url_request_delegate.cc ('k') | content/browser/geolocation/network_location_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/geolocation/geolocation_provider_impl_unittest.cc

diff --git a/content/browser/geolocation/geolocation_provider_impl_unittest.cc b/content/browser/geolocation/geolocation_provider_impl_unittest.cc

index 3ba4dae1baa22819d6a26dd59f59e804cef77ac6..491856bfa9982c8c4eea61150ee2042b1bc2a725 100644

--- a/content/browser/geolocation/geolocation_provider_impl_unittest.cc

+++ b/content/browser/geolocation/geolocation_provider_impl_unittest.cc

@@ -64,7 +64,7 @@ class AsyncMockGeolocationObserver : public MockGeolocationObserver {

public:

void OnLocationUpdate(const Geoposition& position) override {

MockGeolocationObserver::OnLocationUpdate(position);

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}

};

@@ -144,7 +144,7 @@ bool GeolocationProviderTest::ProvidersStarted() {

provider_->task_runner()->PostTaskAndReply(

FROM_HERE, base::Bind(&GeolocationProviderTest::GetProvidersStarted,

base::Unretained(this), &started),

- base::MessageLoop::QuitClosure());

+ base::MessageLoop::QuitWhenIdleClosure());

message_loop_.Run();

return started;

}