content/shell/browser/blink_test_controller.cc - Issue 1398153002: Don't use base::MessageLoop::{Quit,QuitClosure} in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/blink_test_controller.cc

Issue 1398153002: Don't use base::MessageLoop::{Quit,QuitClosure} in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/gpu/render_widget_compositor_unittest.cc ('k') | content/shell/browser/layout_test/layout_test_browser_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/blink_test_controller.cc

diff --git a/content/shell/browser/blink_test_controller.cc b/content/shell/browser/blink_test_controller.cc

index b9e84e5ae68b68654d8068a9a4e113cfdd906cf6..39ab1da6c5207455d6c1fa2ff0aa77c6fd2153e1 100644

--- a/content/shell/browser/blink_test_controller.cc

+++ b/content/shell/browser/blink_test_controller.cc

@@ -498,7 +498,7 @@ void BlinkTestController::DiscardMainWindow() {

if (test_phase_ != BETWEEN_TESTS) {

Shell::CloseAllWindows();

base::ThreadTaskRunnerHandle::Get()->PostTask(

- FROM_HERE, base::MessageLoop::QuitClosure());

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

test_phase_ = CLEAN_UP;

} else if (main_window_) {

main_window_->Close();

@@ -701,14 +701,14 @@ void BlinkTestController::OnResetDone() {

}

base::ThreadTaskRunnerHandle::Get()->PostTask(

- FROM_HERE, base::MessageLoop::QuitClosure());

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

}

void BlinkTestController::OnLeakDetectionDone(

const LeakDetectionResult& result) {

if (!result.leaked) {

base::ThreadTaskRunnerHandle::Get()->PostTask(

- FROM_HERE, base::MessageLoop::QuitClosure());

+ FROM_HERE, base::MessageLoop::QuitWhenIdleClosure());

return;

}