content/browser/fileapi/file_system_operation_impl_write_unittest.cc - Issue 1398153002: Don't use base::MessageLoop::{Quit,QuitClosure} in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/fileapi/file_system_operation_impl_write_unittest.cc

Issue 1398153002: Don't use base::MessageLoop::{Quit,QuitClosure} in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/download/mhtml_generation_browsertest.cc ('k') | content/browser/fileapi/file_writer_delegate_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/fileapi/file_system_operation_impl_write_unittest.cc

diff --git a/content/browser/fileapi/file_system_operation_impl_write_unittest.cc b/content/browser/fileapi/file_system_operation_impl_write_unittest.cc

index ae3277fc2c86ffb41e2558467c625b33a028fea4..76879f4d28b1ed7c6d36aba5f05d3b40f3aa2682 100644

--- a/content/browser/fileapi/file_system_operation_impl_write_unittest.cc

+++ b/content/browser/fileapi/file_system_operation_impl_write_unittest.cc

@@ -131,14 +131,14 @@ class FileSystemOperationImplWriteTest

if (status == base::File::FILE_OK) {

add_bytes_written(bytes, complete);

if (complete)

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

} else {

EXPECT_FALSE(complete_);

EXPECT_EQ(status_, base::File::FILE_OK);

complete_ = true;

status_ = status;

if (base::MessageLoop::current()->is_running())

- base::MessageLoop::current()->Quit();

+ base::MessageLoop::current()->QuitWhenIdle();

}