Improve shaping segmentation for grapheme cluster based font fallback

Improve shaping segmentation for grapheme cluster based font fallback

Previously our pre-shaping segmentation relied on GlyphPageTreeNode for
several different criteria of text segmentation: the font to be used,
upright orientation in vertical text, and small caps behavior. Also, the
pre-shaping stage of script run resolution did not handle braces and
created an extra vector of runs, instead of resolving script runs
incrementally.

As a preparation to this change, ScriptRunIterator, OrientationIterator,
SmallCapsIterator and a RunSegmenter have been introduced to isolate the
run segmentation.

Using RunSegmenter, we can now shape font by font, iterating over the
fonts using a newly introduced FontFallbackIterator.
FontFallbackIterator takes care of providing the shaper with the
available fonts, as specified by CSS, user preference and system
fallback.

The new approach is to let the shaper shape as much as possible of the
current segment, then identify the .notdef sequences. The sequences of
.notdef glyphs are added to a todo list, then shaped with the next
available font.

Bottom line, this fixes several issues we had with chosing base glyph
and combining mark from different fonts, placing them incorrectly,
etc. It also improves our script resolution to handle braces
correctly. It allows us to close a number of bugs related to this area
and should make using subsetted web fonts much more reliable.

It also allows us to finally remove GlyphPageTreeNode and friends, the
core parts of the simple font code path.

BUG=504745
TEST=inspector-protocol/layout-fonts/unicode-range-combining-chars-fallback.html

Committed: https://crrev.com/9f6a2b03ccb7091804f173b70b5facff7dffbd61
Cr-Commit-Position: refs/heads/master@{#355800}

[drott, 2015-10-14 07:38:50]

drott@chromium.org changed reviewers:
+ behdad@chromium.org, eae@chromium.org

[eae, 2015-10-14 08:12:01]

This is awesome!

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp (left):

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp:457: if
(!m_combiningCharacterSequenceSupport)
This also means we can remove m_combiningCharacterSequenceSupport from
SimpleFontData.h, right?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
(right):

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:839:
FontPlatformData* platformData =
const_cast<FontPlatformData*>(&(currentFont->platformData()));
Is this const_cast really needed? harfBuzzFace() is marked as const and that
looks like the only method called on platformData.

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:854:
hb_buffer_add_utf16(harfBuzzBuffer, &preContext, 1, 1, 0);
We don't need this any more, right? (If you want to remove it in a subsequent
change that's perfectly fine).

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:867:
ShapeResult* shapeResult,
const ShapeResult?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:885: int
numGlyphs = hb_buffer_get_length(harfBuzzBuffer);
unsigned?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:888: int
lastChangePosition = 0;
unsigned

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:895: for
(int j = 0; j <= numGlyphs; ++j) {
unsigned glyphIndex or i?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:908:
currentClusterResult = currentClusterResult == Shaped ? Shaped : NotDef;
When would currentClusterResult be anything but Shaped if codepoint is non-zero?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:922: }
This logic is a little hard to follow. If the currentClusterResult is NotDef
then it's set to Shaped, if it's Shaped it is set to NotDef.

Did I get that right? If so wouldn't the following be easier:
previousClusterResult = currentClusterResult;
currentClusterResult = currentClusterResult == NotDef ? Shaped : NotDef;

Also, this needs a better comment explaining why we flip it.

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:932: int
numCharacters = 0;
Can we use unsigned for these? Mixing signed and unsigned (or even using signed
for offsets) makes me a bit nervous.

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:944: } else
{
// Direction Backwards

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:974: if
((currentClusterResult == NotDef && numCharacters != 0) || isLastResort) {
&& numCharacters will do. No need to have the explicit comparison as it cannot
be negative.

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:989: static
inline const SimpleFontData* mangleFontDirection(const SimpleFontData*
originalFont,
The name makes it sound like this operates on the direction and returns a
mangled direction value. How about something like
fontDataAdjustedForOrientation?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:1016:
UTF16TextIterator iterator(m_normalizedBuffer.get() + it->m_startIndex,
it->m_numCharacters);
Could we add an assert ensuring that the index is less than the size of the
normalizedBuffer?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:1039:
RunSegmenter::RunSegmenterRange segmentRange = {0, 0, USCRIPT_INVALID_CODE,
OrientationIterator::OrientationInvalid, SmallCapsIterator::SmallCapsSameCase };
These two lines are really long at > 150, would you mind breaking them?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:1049:
m_holesQueue.append(HolesQueueItem(HolesQueueNextFont, 0, 0));
Having a static helper for appending might make this easer to read

appendToHolesQueue(HolesQueueNextFont, 0, 0);
appendToHolesQueue(HolesQueueRange, segmentRange.start, 
      segmentRange.end - segmentRange.start);

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:1138: for
(int i = 0; i < numGlyphs; ++i) {
unsigned, pretty please?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h (right):

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h:144: inline
bool shapeRange(hb_buffer_t* harfBuzzBuffer, int startIndex, int numCharacters,
const SimpleFontData* currentFont, UScriptCode currentRunScript, hb_language_t);
How about using unsigned for startIndex and numCharacters?

https://codereview.chromium.org/1397423004/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h:146: bool
buildHint(Vector<UChar32>& hint, bool needsList);
This could use a better name or a comment.

[eae, 2015-10-14 08:35:45]

The CQ bit was checked by eae@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-14 08:36:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/1

[commit-bot: I haz the power, 2015-10-14 09:48:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-14 09:48:05]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[eae, 2015-10-14 13:00:40]

Thanks for making the suggested changes and for adding detailed comments!

https://codereview.chromium.org/1397423004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
(right):

https://codereview.chromium.org/1397423004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp:910: //
characters have been shaped, too.
Got it, that makes sense. Thanks for adding the comment.

https://codereview.chromium.org/1397423004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h (right):

https://codereview.chromium.org/1397423004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.h:237: bool
collectFallbackHintChars(Vector<UChar32>& hint, bool needsList);
Much clearer, thank you!

[eae, 2015-10-14 13:00:50]

LGTM!

[drott, 2015-10-14 13:22:47]

The CQ bit was checked by drott@chromium.org

[drott, 2015-10-14 13:22:47]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1397423004/#ps50001
(title: "Requesting rebaselines")

[commit-bot: I haz the power, 2015-10-14 13:23:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/50001

[drott, 2015-10-14 14:27:21]

The CQ bit was unchecked by drott@chromium.org

[drott, 2015-10-14 14:27:30]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2015-10-14 14:27:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/50001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/50001

[commit-bot: I haz the power, 2015-10-14 14:52:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-14 14:52:10]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[drott, 2015-10-15 11:00:27]

The CQ bit was checked by drott@chromium.org

[drott, 2015-10-15 11:00:27]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1397423004/#ps70001
(title: "TestExpectations adjustments")

[commit-bot: I haz the power, 2015-10-15 11:00:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/70001

[commit-bot: I haz the power, 2015-10-15 12:26:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 12:26:58]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[drott, 2015-10-15 13:44:48]

rebaseline updates

[drott, 2015-10-15 13:45:08]

The CQ bit was checked by drott@chromium.org

[drott, 2015-10-15 13:45:08]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1397423004/#ps90001
(title: "rebaseline updates")

[commit-bot: I haz the power, 2015-10-15 13:45:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/90001

[drott, 2015-10-15 15:51:43]

windows expectations updated

[drott, 2015-10-15 15:51:48]

The CQ bit was checked by drott@chromium.org

[drott, 2015-10-15 15:51:48]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1397423004/#ps110001
(title: "windows expectations updated")

[commit-bot: I haz the power, 2015-10-15 15:52:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/110001

[commit-bot: I haz the power, 2015-10-15 18:35:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 18:35:10]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[drott, 2015-10-15 19:56:10]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2015-10-15 19:56:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/110001

[commit-bot: I haz the power, 2015-10-15 23:07:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-15 23:07:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[drott, 2015-10-16 04:47:07]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2015-10-16 04:47:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/110001

[commit-bot: I haz the power, 2015-10-16 04:52:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 04:52:23]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[drott, 2015-10-16 06:40:12]

rebased

[drott, 2015-10-16 06:40:33]

The CQ bit was checked by drott@chromium.org

[drott, 2015-10-16 06:40:33]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1397423004/#ps130001
(title: "rebased")

[commit-bot: I haz the power, 2015-10-16 06:41:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/130001

[drott, 2015-10-16 07:35:07]

ImageOnlyFailure => Failure

[drott, 2015-10-16 07:41:44]

The CQ bit was checked by drott@chromium.org

[drott, 2015-10-16 07:41:45]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1397423004/#ps150001
(title: "ImageOnlyFailure => Failure")

[commit-bot: I haz the power, 2015-10-16 07:42:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/150001

[commit-bot: I haz the power, 2015-10-16 08:28:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 08:28:04]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2015-10-19 08:44:17]

The CQ bit was checked by drott@chromium.org

[drott, 2015-10-19 08:44:17]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1397423004/#ps170001
(title: "Another attempt")

[commit-bot: I haz the power, 2015-10-19 08:44:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/170001

[drott, 2015-10-19 08:46:10]

The CQ bit was unchecked by drott@chromium.org

[drott, 2015-10-19 09:37:21]

rebased

[drott, 2015-10-19 09:37:35]

The CQ bit was checked by drott@chromium.org

[drott, 2015-10-19 09:37:35]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org
Link to the patchset: https://codereview.chromium.org/1397423004/#ps190001
(title: "rebased")

[commit-bot: I haz the power, 2015-10-19 09:38:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/190001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/190001

[commit-bot: I haz the power, 2015-10-19 11:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-19 11:21:21]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[drott, 2015-10-20 08:44:19]

Fallback to next while loading, unicode-range restrictions

[drott, 2015-10-20 08:46:36]

Patchset #12 (id:210001) has been deleted

[drott, 2015-10-20 08:47:24]

Fallback to next while loading, unicode-range restrictions

[behdad, 2015-10-20 19:15:20]

lgtm

[drott, 2015-10-20 19:59:36]

Rebase on top of updated font-face-unicode-range test and moved FontDataRange

[drott, 2015-10-20 20:11:22]

Patchset #14 (id:270001) has been deleted

[drott, 2015-10-20 20:12:37]

Rebase on top of updated font-face-unicode-range test and moved FontDataRange

[drott, 2015-10-21 05:50:04]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-21 05:50:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/290001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/290001

[commit-bot: I haz the power, 2015-10-21 05:50:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 05:50:25]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[drott, 2015-10-21 08:00:03]

Patchset #14 (id:290001) has been deleted

[drott, 2015-10-21 08:00:30]

Rebase on top of updated font-face-unicode-range test and moved FontDataRange

[drott, 2015-10-21 12:09:51]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-21 12:10:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/310001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/310001

[commit-bot: I haz the power, 2015-10-21 13:01:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-21 13:01:52]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[drott, 2015-10-22 08:28:01]

fix additional fallback load triggers, contains harfbuzz compat decomp fix

[drott, 2015-10-22 08:28:14]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 08:28:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/330001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/330001

[commit-bot: I haz the power, 2015-10-22 09:24:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 09:24:18]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2015-10-22 11:47:32]

hopefully last round of TestExpectations tweaks

[drott, 2015-10-22 11:47:50]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 11:48:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/350001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/350001

[commit-bot: I haz the power, 2015-10-22 13:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 13:06:13]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[drott, 2015-10-22 13:19:32]

a few more Win rebaselines

[drott, 2015-10-22 13:19:54]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-22 13:20:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/370001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/370001

[commit-bot: I haz the power, 2015-10-22 14:32:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-22 14:32:36]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[drott, 2015-10-22 15:05:20]

Okay, I think this is ready now, together with
https://codereview.chromium.org/1418533006/ and
https://codereview.chromium.org/1416013004/#. It would be great, Emil, if you
have some time to review the most recent changes:

a) Plumbing the unicode-range parameters through to HarfBuzzFace so that the
given segmented font is only used for that range.
b) Avoiding falling back and triggering load of another segmented web font when
unicode-ranges overlap (change in FontFallbackIterator to have map of the
loading ranges)
c) Identified an issue with b) for AAT fonts, filed as crbug.com/545555
d) Identified an issue with HarfBuzz doing unicode compatibility decomposition,
leading to suboptimal glyph substitutions, addressed in
https://codereview.chromium.org/1416013004/#
e) Fixed one more test in https://codereview.chromium.org/1418533006/

Given that the two other CLs would land, this can land, too, I believe.
Thanks in advance!

[drott, 2015-10-23 11:24:40]

Rebased on top of updated HarfBuzz

[drott, 2015-10-23 11:25:10]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 11:25:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/390001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/390001

[commit-bot: I haz the power, 2015-10-23 12:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 12:26:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2015-10-23 12:34:48]

merge TestExpectations with the HarfBuzz rebaselines

[drott, 2015-10-23 12:35:17]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-23 12:35:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/410001

[commit-bot: I haz the power, 2015-10-23 15:15:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-23 15:15:25]

Dry run: This issue passed the CQ dry run.

[eae, 2015-10-23 16:24:04]

LGTM

[drott, 2015-10-23 16:24:27]

The CQ bit was checked by drott@chromium.org

[drott, 2015-10-23 16:24:28]

The patchset sent to the CQ was uploaded after l-g-t-m from behdad@chromium.org
Link to the patchset: https://codereview.chromium.org/1397423004/#ps410001
(title: "merge TestExpectations with the HarfBuzz rebaselines")

[commit-bot: I haz the power, 2015-10-23 16:25:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1397423004/410001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1397423004/410001

[commit-bot: I haz the power, 2015-10-23 16:29:58]

Committed patchset #19 (id:410001)

[drott, 2015-10-23 16:30:45]

Hella Yout and Halleluja! \o/

[commit-bot: I haz the power, 2015-10-23 16:30:57]

Patchset 19 (id:??) landed as
https://crrev.com/9f6a2b03ccb7091804f173b70b5facff7dffbd61
Cr-Commit-Position: refs/heads/master@{#355800}

[Nico, 2015-10-24 16:18:03]

I believe this caused some test failures. Filed
https://code.google.com/p/chromium/issues/detail?id=547390