third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h - Issue 1397423004: Improve shaping segmentation for grapheme cluster based font fallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

Issue 1397423004: Improve shaping segmentation for grapheme cluster based font fallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge TestExpectations with the HarfBuzz rebaselines Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

index 06170725332b3a843cb7bb9fcaa1666842abb021..d59f9b6a1b87d1b34dbf3a9c40758ecaa4d616ae 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.h

@@ -35,6 +35,7 @@

#include "wtf/PassRefPtr.h"

#include "wtf/RefCounted.h"

#include "wtf/RefPtr.h"

+#include "wtf/text/CharacterNames.h"

#include <hb.h>

@@ -53,7 +54,10 @@ public:

}

~HarfBuzzFace();

- hb_font_t* createFont() const;

+ // In order to support the restricting effect of unicode-range optionally a

+ // range restriction can be passed in, which will restrict which glyphs we

+ // return in the harfBuzzGetGlyph function.

+ hb_font_t* createFont(unsigned rangeFrom = 0, unsigned rangeTo = kMaxCodepoint) const;

hb_face_t* face() const { return m_face; }

private: