Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1416013004: Cherry pick disabled unicode compatibility decomposition into HarfBuzz (Closed)

Created:
5 years, 2 months ago by drott
Modified:
5 years, 2 months ago
Reviewers:
eae, behdad
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cherry pick disabled unicode compatibility decomposition into HarfBuzz HarfBuzz commit f6799700404c49ae0 disables unicode compatibility decomposition, avoiding undesirable substitutions and allowing Blink to fall back to system fonts for mathematical symbols and the like. Cherry-picking this into our HarfBuzz version in order to be able to land shaper driven segmentation. BUG=546454 R=behdad,eae Committed: https://crrev.com/c6da2801d9e36a9f2bb5acf4e3c492c8f0680ad4 Cr-Commit-Position: refs/heads/master@{#355551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -25 lines) Patch
M third_party/harfbuzz-ng/README.chromium View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/harfbuzz-ng/src/hb-ot-shape-normalize.cc View 2 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
drott
behdad@ do you think we can cherry-pick this or should we wait for work on ...
5 years, 2 months ago (2015-10-22 08:29:13 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416013004/1
5 years, 2 months ago (2015-10-22 15:02:04 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 15:55:56 UTC) #5
behdad
lgtm
5 years, 2 months ago (2015-10-22 16:33:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1416013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1416013004/1
5 years, 2 months ago (2015-10-22 16:37:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-22 16:41:24 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c6da2801d9e36a9f2bb5acf4e3c492c8f0680ad4 Cr-Commit-Position: refs/heads/master@{#355551}
5 years, 2 months ago (2015-10-22 16:42:16 UTC) #12
Justin Novosad
5 years, 2 months ago (2015-10-22 20:46:44 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1409993005/ by junov@chromium.org.

The reason for reverting is: This change is causing bllink layout test failures
on multiple platforms. Judging from the diffs, this looks like a regression, not
just something that needs rebaselining.

fast/text/unicode-fallback-font.html (windows only)
fast/text/midword-break-before-surrogate-pair.html (windows only)
svg/text/non-bmp-positioning-lists.svg

Affected platforms: 
Mac 10.6 only
Win XP, 7 and 10
Linux 64, 32 and Trusty.

Powered by Google App Engine
This is Rietveld 408576698