Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1418533006: Remove fallback rules in rtl-ordering.html test (Closed)

Created:
5 years, 2 months ago by drott
Modified:
5 years, 1 month ago
Reviewers:
eae, behdad
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove fallback rules in rtl-ordering.html test Issue 545555 describes that unicode-range restricting AAT fonts does not work properly at the moment. Since Lucida Grande is an AAT font on Mac, this test case has slight pixel differences on Mac, since Lucida Grande gets selected to render the "21-" digits in the second line. Let's remove the explicit fallback declarations, the test should work without them. BUG=545555 R=eae,behdad Committed: https://crrev.com/33661a3ffa9543d345210a604fc7f1b6a70de943 Cr-Commit-Position: refs/heads/master@{#355575}

Patch Set 1 #

Patch Set 2 : Mac Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/rtl-ordering.html View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418533006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418533006/1
5 years, 2 months ago (2015-10-22 10:58:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418533006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418533006/20001
5 years, 2 months ago (2015-10-22 11:45:22 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-22 12:24:54 UTC) #6
drott
5 years, 2 months ago (2015-10-22 13:20:22 UTC) #7
eae
LGTM
5 years, 2 months ago (2015-10-22 17:40:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1418533006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1418533006/20001
5 years, 2 months ago (2015-10-22 17:41:05 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-22 17:47:30 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/33661a3ffa9543d345210a604fc7f1b6a70de943 Cr-Commit-Position: refs/heads/master@{#355575}
5 years, 2 months ago (2015-10-22 17:48:17 UTC) #12
drott
Great, thanks for the review and committing it. Now all blockers should be out of ...
5 years, 2 months ago (2015-10-22 17:49:50 UTC) #13
behdad
5 years, 1 month ago (2015-10-26 20:53:16 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698