Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1395383002: SkBitmapRegionDecoder clean-up (Closed)

Created:
5 years, 2 months ago by msarett
Modified:
5 years, 2 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkBitmapRegionDecoder clean-up Use SkCodecPrintf instead of SkDebugf. Check if the conversion is possible rather than starting many decodes that will certainly fail. Small refactor to code that deals with subsets that fall outside of the image. BUG=skia: Committed: https://skia.googlesource.com/skia/+/04965c6f112565c02926bc9a230e6da5f400d07a

Patch Set 1 #

Patch Set 2 : Forgot to modify DMSrcSink #

Total comments: 2

Patch Set 3 : Response to comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -28 lines) Patch
M dm/DMSrcSink.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tools/SkBitmapRegionCanvas.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/SkBitmapRegionCanvas.cpp View 1 2 11 chunks +30 lines, -23 lines 0 comments Download
M tools/SkBitmapRegionDecoderInterface.h View 1 chunk +5 lines, -0 lines 0 comments Download
M tools/SkBitmapRegionDecoderInterface.cpp View 4 chunks +5 lines, -4 lines 0 comments Download
M tools/SkBitmapRegionSampler.h View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/SkBitmapRegionSampler.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1188223002 Patch 40001

Messages

Total messages: 8 (3 generated)
msarett
Another CL that I'm pulling out of SkScaled (subset) Codec.
5 years, 2 months ago (2015-10-12 15:27:01 UTC) #2
scroggo
lgtm https://codereview.chromium.org/1395383002/diff/20001/tools/SkBitmapRegionCanvas.cpp File tools/SkBitmapRegionCanvas.cpp (right): https://codereview.chromium.org/1395383002/diff/20001/tools/SkBitmapRegionCanvas.cpp#newcode24 tools/SkBitmapRegionCanvas.cpp:24: inline bool set_subset_region(int inputOffset, int inputDimension, Why is ...
5 years, 2 months ago (2015-10-12 17:04:57 UTC) #3
msarett
https://codereview.chromium.org/1395383002/diff/20001/tools/SkBitmapRegionCanvas.cpp File tools/SkBitmapRegionCanvas.cpp (right): https://codereview.chromium.org/1395383002/diff/20001/tools/SkBitmapRegionCanvas.cpp#newcode24 tools/SkBitmapRegionCanvas.cpp:24: inline bool set_subset_region(int inputOffset, int inputDimension, On 2015/10/12 17:04:57, ...
5 years, 2 months ago (2015-10-12 17:16:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1395383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1395383002/40001
5 years, 2 months ago (2015-10-12 17:17:27 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-12 17:24:40 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/04965c6f112565c02926bc9a230e6da5f400d07a

Powered by Google App Engine
This is Rietveld 408576698