Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: tools/SkBitmapRegionSampler.h

Issue 1395383002: SkBitmapRegionDecoder clean-up (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Response to comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/SkBitmapRegionDecoderInterface.cpp ('k') | tools/SkBitmapRegionSampler.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBitmap.h" 8 #include "SkBitmap.h"
9 #include "SkBitmapRegionDecoderInterface.h" 9 #include "SkBitmapRegionDecoderInterface.h"
10 #include "SkImageDecoder.h" 10 #include "SkImageDecoder.h"
(...skipping 14 matching lines...) Expand all
25 /* 25 /*
26 * Three differences from the Android version: 26 * Three differences from the Android version:
27 * Returns a Skia bitmap instead of an Android bitmap. 27 * Returns a Skia bitmap instead of an Android bitmap.
28 * Android version attempts to reuse a recycled bitmap. 28 * Android version attempts to reuse a recycled bitmap.
29 * Removed the options object and used parameters for color type and 29 * Removed the options object and used parameters for color type and
30 * sample size. 30 * sample size.
31 */ 31 */
32 SkBitmap* decodeRegion(int start_x, int start_y, int width, int height, 32 SkBitmap* decodeRegion(int start_x, int start_y, int width, int height,
33 int sampleSize, SkColorType prefColorType) override; 33 int sampleSize, SkColorType prefColorType) override;
34 34
35 bool conversionSupported(SkColorType colorType) override {
36 // SkBitmapRegionSampler does not allow the client to check if the conve rsion
37 // is supported. We will return true as a default. If the conversion i s in
38 // fact not supported, decodeRegion() will ignore the prefColorType and choose
39 // its own color type. We catch this and fail non-fatally in our test c ode.
40 return true;
41 }
42
35 private: 43 private:
36 44
37 SkAutoTDelete<SkImageDecoder> fDecoder; 45 SkAutoTDelete<SkImageDecoder> fDecoder;
38 46
39 typedef SkBitmapRegionDecoderInterface INHERITED; 47 typedef SkBitmapRegionDecoderInterface INHERITED;
40 48
41 }; 49 };
OLDNEW
« no previous file with comments | « tools/SkBitmapRegionDecoderInterface.cpp ('k') | tools/SkBitmapRegionSampler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698