Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: tools/SkBitmapRegionSampler.h

Issue 1395383002: SkBitmapRegionDecoder clean-up (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Response to comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/SkBitmapRegionDecoderInterface.cpp ('k') | tools/SkBitmapRegionSampler.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/SkBitmapRegionSampler.h
diff --git a/tools/SkBitmapRegionSampler.h b/tools/SkBitmapRegionSampler.h
index d2f738d3b5545d220c4d00cacf5f7ca855b30fd2..8ed95e25249b1cd4092fd095ca601c8c4164a33d 100644
--- a/tools/SkBitmapRegionSampler.h
+++ b/tools/SkBitmapRegionSampler.h
@@ -32,6 +32,14 @@ public:
SkBitmap* decodeRegion(int start_x, int start_y, int width, int height,
int sampleSize, SkColorType prefColorType) override;
+ bool conversionSupported(SkColorType colorType) override {
+ // SkBitmapRegionSampler does not allow the client to check if the conversion
+ // is supported. We will return true as a default. If the conversion is in
+ // fact not supported, decodeRegion() will ignore the prefColorType and choose
+ // its own color type. We catch this and fail non-fatally in our test code.
+ return true;
+ }
+
private:
SkAutoTDelete<SkImageDecoder> fDecoder;
« no previous file with comments | « tools/SkBitmapRegionDecoderInterface.cpp ('k') | tools/SkBitmapRegionSampler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698