Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 139493008: [android_webview] Call onPageFinished for anchor navigations. (Closed)

Created:
6 years, 10 months ago by mkosiba (inactive)
Modified:
6 years, 10 months ago
Reviewers:
Ted C, jdduke (slow), mnaganov (inactive), mnaganov
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, android-webview-reviews_chromium.org, jdduke (slow)
Visibility:
Public.

Description

[android_webview] Call onPageFinished for anchor navigations. This makes the android_webview call onPageFinished for navigations which only result in the hash fragment being changed. This bug was introduced when we switched from didStopLoading to didFinishLoad. BUG=341085, 291747 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249142

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : fix indent #

Messages

Total messages: 8 (0 generated)
mkosiba (inactive)
jdduke@ for WebContentsObserverAndroid mnaganov@ for android_webview
6 years, 10 months ago (2014-02-05 17:36:41 UTC) #1
jdduke (slow)
This looks fine, though it might be a stretch for me to claim ownership for ...
6 years, 10 months ago (2014-02-05 17:55:17 UTC) #2
Ted C
content changes lgtm https://codereview.chromium.org/139493008/diff/20001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java File content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java (right): https://codereview.chromium.org/139493008/diff/20001/content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java#newcode66 content/public/android/java/src/org/chromium/content/browser/WebContentsObserverAndroid.java:66: * document (for example scrolling to ...
6 years, 10 months ago (2014-02-05 17:58:52 UTC) #3
mnaganov (inactive)
android_webview/ LGTM w/ nit https://codereview.chromium.org/139493008/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java File android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java (right): https://codereview.chromium.org/139493008/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java#newcode218 android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:218: final String data, final String ...
6 years, 10 months ago (2014-02-05 18:02:24 UTC) #4
mkosiba (inactive)
thanks! https://codereview.chromium.org/139493008/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java File android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java (right): https://codereview.chromium.org/139493008/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java#newcode218 android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:218: final String data, final String mimeType, final boolean ...
6 years, 10 months ago (2014-02-05 18:24:58 UTC) #5
mkosiba (inactive)
The CQ bit was checked by mkosiba@chromium.org
6 years, 10 months ago (2014-02-05 18:25:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkosiba@chromium.org/139493008/110001
6 years, 10 months ago (2014-02-05 18:45:04 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 22:19:49 UTC) #8
Message was sent while issue was closed. 
Change committed as 249142

Powered by Google App Engine
This is Rietveld 408576698