Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java

Issue 139493008: [android_webview] Call onPageFinished for anchor navigations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indent Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
index c09c41ebee6e35dc25a2a7dc950073a82072699b..5acc3abf18f1dba923935eb248a843c887ebc1f4 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
@@ -335,6 +335,16 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
@SmallTest
@Feature({"AndroidWebView", "Navigation"})
public void testNotCalledForAnchorNavigations() throws Throwable {
+ doTestNotCalledForAnchorNavigations(false);
+ }
+
+ @SmallTest
+ @Feature({"AndroidWebView", "Navigation"})
+ public void testNotCalledForAnchorNavigationsWithNonHierarchicalScheme() throws Throwable {
+ doTestNotCalledForAnchorNavigations(true);
+ }
+
+ private void doTestNotCalledForAnchorNavigations(boolean useLoadData) throws Throwable {
final TestAwContentsClient contentsClient = new TestAwContentsClient();
final AwTestContainerView testContainerView =
createAwTestContainerViewOnMainSync(contentsClient);
@@ -347,7 +357,12 @@ public class AwContentsClientShouldOverrideUrlLoadingTest extends AwTestBase {
addPageToTestServer(mWebServer, anchorLinkPath,
getHtmlForPageWithSimpleLinkTo(anchorLinkUrl + "#anchor"));
- loadUrlSync(awContents, contentsClient.getOnPageFinishedHelper(), anchorLinkUrl);
+ if (useLoadData) {
+ loadDataSync(awContents, contentsClient.getOnPageFinishedHelper(),
+ getHtmlForPageWithSimpleLinkTo("#anchor"), "text/html", false);
+ } else {
+ loadUrlSync(awContents, contentsClient.getOnPageFinishedHelper(), anchorLinkUrl);
+ }
final int shouldOverrideUrlLoadingCallCount =
shouldOverrideUrlLoadingHelper.getCallCount();

Powered by Google App Engine
This is Rietveld 408576698