Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java

Issue 139493008: [android_webview] Call onPageFinished for anchor navigations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indent Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
index 14a7001acdbfa594b0c14ff32d256cb6b908d6ce..aaaa6cc5860a6e385f7a1200c59f7d26345145a0 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java
@@ -7,6 +7,8 @@ package org.chromium.android_webview.test;
import android.test.suitebuilder.annotation.MediumTest;
import org.chromium.android_webview.AwContents;
+import org.chromium.android_webview.test.util.CommonResources;
+import org.chromium.android_webview.test.util.JSUtils;
import org.chromium.base.test.util.Feature;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
import org.chromium.net.test.util.TestWebServer;
@@ -153,4 +155,61 @@ public class ClientOnPageFinishedTest extends AwTestBase {
if (webServer != null) webServer.shutdown();
}
}
+
+ @MediumTest
+ @Feature({"AndroidWebView"})
+ public void testOnPageFinishedCalledForHrefNavigations() throws Throwable {
+ doTestOnPageFinishedCalledForHrefNavigations(false);
+ }
+
+ @MediumTest
+ @Feature({"AndroidWebView"})
+ public void testOnPageFinishedCalledForHrefNavigationsWithBaseUrl() throws Throwable {
+ doTestOnPageFinishedCalledForHrefNavigations(true);
+ }
+
+ private void doTestOnPageFinishedCalledForHrefNavigations(boolean useBaseUrl) throws Throwable {
+ TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHelper =
+ mContentsClient.getOnPageFinishedHelper();
+ TestCallbackHelperContainer.OnPageStartedHelper onPageStartedHelper =
+ mContentsClient.getOnPageStartedHelper();
+ enableJavaScriptOnUiThread(mAwContents);
+
+ TestWebServer webServer = null;
+ try {
+ webServer = new TestWebServer(false);
+
+ final String testHtml = CommonResources.makeHtmlPageFrom("",
+ "<a href=\"#anchor\" id=\"link\">anchor</a>");
+ final String testPath = "/test.html";
+ final String testUrl = webServer.setResponse(testPath, testHtml, null);
+
+ if (useBaseUrl) {
+ loadDataWithBaseUrlSync(mAwContents, onPageFinishedHelper,
+ testHtml, "text/html", false, webServer.getBaseUrl(), null);
+ } else {
+ loadUrlSync(mAwContents, onPageFinishedHelper, testUrl);
+ }
+
+ int onPageFinishedCallCount = onPageFinishedHelper.getCallCount();
+ int onPageStartedCallCount = onPageStartedHelper.getCallCount();
+
+ JSUtils.clickOnLinkUsingJs(this, mAwContents,
+ mContentsClient.getOnEvaluateJavaScriptResultHelper(), "link");
+
+ onPageFinishedHelper.waitForCallback(onPageFinishedCallCount);
+ assertEquals(onPageStartedCallCount, onPageStartedHelper.getCallCount());
+
+ onPageFinishedCallCount = onPageFinishedHelper.getCallCount();
+ onPageStartedCallCount = onPageStartedHelper.getCallCount();
+
+ executeJavaScriptAndWaitForResult(mAwContents, mContentsClient,
+ "window.history.go(-1)");
+
+ onPageFinishedHelper.waitForCallback(onPageFinishedCallCount);
+ assertEquals(onPageStartedCallCount, onPageStartedHelper.getCallCount());
+ } finally {
+ if (webServer != null) webServer.shutdown();
+ }
+ }
}

Powered by Google App Engine
This is Rietveld 408576698