Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: content/browser/android/web_contents_observer_android.cc

Issue 139493008: [android_webview] Call onPageFinished for anchor navigations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indent Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/web_contents_observer_android.cc
diff --git a/content/browser/android/web_contents_observer_android.cc b/content/browser/android/web_contents_observer_android.cc
index 235041be67422e2924b9bf106d613693048a5df0..797ea3b1af92afc3ea23ab2b2b75ab31bc6e2ae9 100644
--- a/content/browser/android/web_contents_observer_android.cc
+++ b/content/browser/android/web_contents_observer_android.cc
@@ -130,9 +130,16 @@ void WebContentsObserverAndroid::DidNavigateMainFrame(
ConvertUTF8ToJavaString(env, params.url.spec()));
ScopedJavaLocalRef<jstring> jstring_base_url(
ConvertUTF8ToJavaString(env, params.base_url.spec()));
- Java_WebContentsObserverAndroid_didNavigateMainFrame(
+ // See http://crbug.com/251330 for why it's determined this way.
+ bool in_page_navigation =
+ details.type == NAVIGATION_TYPE_IN_PAGE || details.is_in_page;
+ // TODO(mkosiba): delete once downstream rolls.
+ Java_WebContentsObserverAndroid_didNavigateMainFrameV_JLS_JLS_Z(
env, obj.obj(), jstring_url.obj(), jstring_base_url.obj(),
details.is_navigation_to_different_page());
+ Java_WebContentsObserverAndroid_didNavigateMainFrameV_JLS_JLS_Z_Z(
+ env, obj.obj(), jstring_url.obj(), jstring_base_url.obj(),
+ details.is_navigation_to_different_page(), in_page_navigation);
}
void WebContentsObserverAndroid::DidNavigateAnyFrame(

Powered by Google App Engine
This is Rietveld 408576698