Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3434)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java

Issue 139493008: [android_webview] Call onPageFinished for anchor navigations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix indent Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java
index 4163d76691b9b2745ebbcd3696ae509d12088d8c..65b90dc0614f79e91fb1950a342d263bafbc243d 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/LoadDataWithBaseUrlTest.java
@@ -13,7 +13,6 @@ import org.chromium.android_webview.test.util.CommonResources;
import org.chromium.base.test.util.DisabledTest;
import org.chromium.base.test.util.Feature;
import org.chromium.content.browser.ContentViewCore;
-import org.chromium.content.browser.LoadUrlParams;
import org.chromium.content.browser.test.util.HistoryUtils;
import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
import org.chromium.net.test.util.TestWebServer;
@@ -21,7 +20,6 @@ import org.chromium.net.test.util.TestWebServer;
import java.io.File;
import java.io.FileOutputStream;
import java.util.concurrent.Callable;
-import java.util.concurrent.TimeUnit;
/**
* Tests for the {@link android.webkit.WebView#loadDataWithBaseURL(String, String, String, String,
@@ -46,24 +44,8 @@ public class LoadDataWithBaseUrlTest extends AwTestBase {
protected void loadDataWithBaseUrlSync(
final String data, final String mimeType, final boolean isBase64Encoded,
final String baseUrl, final String historyUrl) throws Throwable {
- TestCallbackHelperContainer.OnPageFinishedHelper onPageFinishedHelper =
- mContentsClient.getOnPageFinishedHelper();
- int currentCallCount = onPageFinishedHelper.getCallCount();
- loadDataWithBaseUrlAsync(data, mimeType, isBase64Encoded, baseUrl, historyUrl);
- onPageFinishedHelper.waitForCallback(currentCallCount, 1, WAIT_TIMEOUT_MS,
- TimeUnit.MILLISECONDS);
- }
-
- protected void loadDataWithBaseUrlAsync(
- final String data, final String mimeType, final boolean isBase64Encoded,
- final String baseUrl, final String historyUrl) throws Throwable {
- runTestOnUiThread(new Runnable() {
- @Override
- public void run() {
- mAwContents.loadUrl(LoadUrlParams.createLoadDataParamsWithBaseUrl(
- data, mimeType, isBase64Encoded, baseUrl, historyUrl));
- }
- });
+ loadDataWithBaseUrlSync(mAwContents, mContentsClient.getOnPageFinishedHelper(),
+ data, mimeType, isBase64Encoded, baseUrl, historyUrl);
}
private static final String SCRIPT_FILE = "/script.js";
@@ -203,8 +185,8 @@ public class LoadDataWithBaseUrlTest extends AwTestBase {
TestCallbackHelperContainer.OnPageStartedHelper onPageStartedHelper =
mContentsClient.getOnPageStartedHelper();
final int callCount = onPageStartedHelper.getCallCount();
- loadDataWithBaseUrlAsync(CommonResources.ABOUT_HTML, "text/html", false, baseUrl,
- "about:blank");
+ loadDataWithBaseUrlAsync(mAwContents, CommonResources.ABOUT_HTML, "text/html", false,
+ baseUrl, "about:blank");
onPageStartedHelper.waitForCallback(callCount);
assertEquals(baseUrl, onPageStartedHelper.getUrl());
}

Powered by Google App Engine
This is Rietveld 408576698