Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1394193003: Invalidate background-attachment:fixed on scroll. (Closed)

Created:
5 years, 2 months ago by trchen
Modified:
5 years, 2 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Invalidate background-attachment:fixed on scroll. If there is any slow repaint objects (i.e. background-attachment:fixed), we fall back to the FrameView::scrollContentsSlowPath() that invalidates the whole main graphics layer. However this is not correct because the object is not necessarily backed by the main backing. We should invalidate them individually. Note: This approach is still not entirely correct. With composited overflow scrolling, we should inhibit threaded scrolling when a slow repaint descandant presents and do similar invalidation. This is non-trivial to implement. As the old compositing architecture is deprecated anyway, we will try to fix the issue with SPv2. BUG=540499 Committed: https://crrev.com/1d3aacc9cd5028db3a36036bfbace8933097be00 Cr-Commit-Position: refs/heads/master@{#354960}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rename all SlowRepaint to BackgroundAttachmentFixed. rebaseline test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -45 lines) Patch
A third_party/WebKit/LayoutTests/compositing/repaint/background-attachment-fixed-scrolled.html View 1 chunk +27 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/compositing/repaint/background-attachment-fixed-scrolled-expected.html View 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/repaint/full-viewport-repaint-for-background-attachment-fixed-expected.txt View 1 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 1 4 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 4 chunks +21 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
trchen
5 years, 2 months ago (2015-10-09 02:44:25 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394193003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394193003/1
5 years, 2 months ago (2015-10-09 02:44:57 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/118502)
5 years, 2 months ago (2015-10-09 03:46:23 UTC) #6
Xianzhu
https://codereview.chromium.org/1394193003/diff/1/third_party/WebKit/Source/core/layout/LayoutObject.cpp File third_party/WebKit/Source/core/layout/LayoutObject.cpp (left): https://codereview.chromium.org/1394193003/diff/1/third_party/WebKit/Source/core/layout/LayoutObject.cpp#oldcode3433 third_party/WebKit/Source/core/layout/LayoutObject.cpp:3433: void LayoutObject::setIsSlowRepaintObject(bool isSlowRepaintObject) Can you also rename this function ...
5 years, 2 months ago (2015-10-12 16:05:51 UTC) #7
chrishtr
I found another report of this in the wild, and dup'ed it against this bug. ...
5 years, 2 months ago (2015-10-16 19:56:06 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394193003/20001
5 years, 2 months ago (2015-10-17 01:52:02 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-17 02:59:28 UTC) #13
Xianzhu
lgtm
5 years, 2 months ago (2015-10-20 01:19:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1394193003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1394193003/20001
5 years, 2 months ago (2015-10-20 01:20:23 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-20 02:39:41 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 02:40:28 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d3aacc9cd5028db3a36036bfbace8933097be00
Cr-Commit-Position: refs/heads/master@{#354960}

Powered by Google App Engine
This is Rietveld 408576698