Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 1394193003: Invalidate background-attachment:fixed on scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2011 Apple Inc. All rights reserv ed.
7 * Copyright (C) 2009 Google Inc. All rights reserved. 7 * Copyright (C) 2009 Google Inc. All rights reserved.
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 3412 matching lines...) Expand 10 before | Expand all | Expand 10 after
3423 { 3423 {
3424 object.setShouldDoFullPaintInvalidation(); 3424 object.setShouldDoFullPaintInvalidation();
3425 } 3425 }
3426 }; 3426 };
3427 3427
3428 // Need to access the current compositing status. 3428 // Need to access the current compositing status.
3429 DisableCompositingQueryAsserts disabler; 3429 DisableCompositingQueryAsserts disabler;
3430 traverseNonCompositingDescendants(*this, Functor()); 3430 traverseNonCompositingDescendants(*this, Functor());
3431 } 3431 }
3432 3432
3433 void LayoutObject::setIsSlowRepaintObject(bool isSlowRepaintObject) 3433 void LayoutObject::setIsSlowRepaintObject(bool isSlowRepaintObject)
Xianzhu 2015/10/12 16:05:51 Can you also rename this function and LayoutBox::u
3434 { 3434 {
3435 ASSERT(frameView()); 3435 ASSERT(frameView());
3436 if (m_bitfields.isSlowRepaintObject() == isSlowRepaintObject) 3436 if (m_bitfields.isSlowRepaintObject() == isSlowRepaintObject)
3437 return; 3437 return;
3438 m_bitfields.setIsSlowRepaintObject(isSlowRepaintObject); 3438 m_bitfields.setIsSlowRepaintObject(isSlowRepaintObject);
3439 if (isSlowRepaintObject) 3439 if (isSlowRepaintObject)
3440 frameView()->addSlowRepaintObject(); 3440 frameView()->addBackgroundAttachmentFixedObject(this);
3441 else 3441 else
3442 frameView()->removeSlowRepaintObject(); 3442 frameView()->removeBackgroundAttachmentFixedObject(this);
3443 } 3443 }
3444 3444
3445 } // namespace blink 3445 } // namespace blink
3446 3446
3447 #ifndef NDEBUG 3447 #ifndef NDEBUG
3448 3448
3449 void showTree(const blink::LayoutObject* object) 3449 void showTree(const blink::LayoutObject* object)
3450 { 3450 {
3451 if (object) 3451 if (object)
3452 object->showTreeForThis(); 3452 object->showTreeForThis();
(...skipping 20 matching lines...) Expand all
3473 const blink::LayoutObject* root = object1; 3473 const blink::LayoutObject* root = object1;
3474 while (root->parent()) 3474 while (root->parent())
3475 root = root->parent(); 3475 root = root->parent();
3476 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0); 3476 root->showLayoutTreeAndMark(object1, "*", object2, "-", 0);
3477 } else { 3477 } else {
3478 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n"); 3478 fprintf(stderr, "Cannot showLayoutTree. Root is (nil)\n");
3479 } 3479 }
3480 } 3480 }
3481 3481
3482 #endif 3482 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698