Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.h

Issue 1394193003: Invalidate background-attachment:fixed on scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename all SlowRepaint to BackgroundAttachmentFixed. rebaseline test. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.h
diff --git a/third_party/WebKit/Source/core/frame/FrameView.h b/third_party/WebKit/Source/core/frame/FrameView.h
index a643ff80fe5adae85253b3c789613643230a0505..a158ee69f571ed405ec32325353a31d160a6ba8a 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.h
+++ b/third_party/WebKit/Source/core/frame/FrameView.h
@@ -187,10 +187,6 @@ public:
WebDisplayMode displayMode() { return m_displayMode; }
void setDisplayMode(WebDisplayMode);
- void addSlowRepaintObject();
- void removeSlowRepaintObject();
- bool hasSlowRepaintObjects() const { return m_slowRepaintObjectCount; }
-
// Fixed-position objects.
typedef HashSet<LayoutObject*> ViewportConstrainedObjectSet;
void addViewportConstrainedObject(LayoutObject*);
@@ -198,6 +194,12 @@ public:
const ViewportConstrainedObjectSet* viewportConstrainedObjects() const { return m_viewportConstrainedObjects.get(); }
bool hasViewportConstrainedObjects() const { return m_viewportConstrainedObjects && m_viewportConstrainedObjects->size() > 0; }
+ // Objects with background-attachment:fixed.
+ void addBackgroundAttachmentFixedObject(LayoutObject*);
+ void removeBackgroundAttachmentFixedObject(LayoutObject*);
+ bool hasBackgroundAttachmentFixedObjects() const { return m_backgroundAttachmentFixedObjects.size(); }
+ void invalidateBackgroundAttachmentFixedObjects();
+
void handleLoadCompleted();
void updateDocumentAnnotatedRegions() const;
@@ -740,7 +742,6 @@ private:
bool m_doFullPaintInvalidation;
bool m_canHaveScrollbars;
- unsigned m_slowRepaintObjectCount;
bool m_hasPendingLayout;
LayoutSubtreeRootList m_layoutSubtreeRootList;
@@ -784,6 +785,7 @@ private:
OwnPtrWillBeMember<ScrollableAreaSet> m_animatingScrollableAreas;
OwnPtr<ResizerAreaSet> m_resizerAreas;
OwnPtr<ViewportConstrainedObjectSet> m_viewportConstrainedObjects;
+ ViewportConstrainedObjectSet m_backgroundAttachmentFixedObjects;
OwnPtrWillBeMember<FrameViewAutoSizeInfo> m_autoSizeInfo;
IntSize m_inputEventsOffsetForEmulation;

Powered by Google App Engine
This is Rietveld 408576698