Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObject.cpp

Issue 1394193003: Invalidate background-attachment:fixed on scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename all SlowRepaint to BackgroundAttachmentFixed. rebaseline test. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObject.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObject.cpp b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
index f4b615a98126bd464e28e838a099c7a38c4dd609..0b6993ab9e04f1ce4821564ce9e4c14974c0a82c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObject.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObject.cpp
@@ -2539,7 +2539,7 @@ void LayoutObject::willBeDestroyed()
}
if (frameView())
- setIsSlowRepaintObject(false);
+ setIsBackgroundAttachmentFixedObject(false);
}
void LayoutObject::insertedIntoTree()
@@ -3443,16 +3443,16 @@ void LayoutObject::invalidatePaintIncludingNonSelfPaintingLayerDescendants(const
}
}
-void LayoutObject::setIsSlowRepaintObject(bool isSlowRepaintObject)
+void LayoutObject::setIsBackgroundAttachmentFixedObject(bool isBackgroundAttachmentFixedObject)
{
ASSERT(frameView());
- if (m_bitfields.isSlowRepaintObject() == isSlowRepaintObject)
+ if (m_bitfields.isBackgroundAttachmentFixedObject() == isBackgroundAttachmentFixedObject)
return;
- m_bitfields.setIsSlowRepaintObject(isSlowRepaintObject);
- if (isSlowRepaintObject)
- frameView()->addSlowRepaintObject();
+ m_bitfields.setIsBackgroundAttachmentFixedObject(isBackgroundAttachmentFixedObject);
+ if (isBackgroundAttachmentFixedObject)
+ frameView()->addBackgroundAttachmentFixedObject(this);
else
- frameView()->removeSlowRepaintObject();
+ frameView()->removeBackgroundAttachmentFixedObject(this);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698