Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1394193003: Invalidate background-attachment:fixed on scroll. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename all SlowRepaint to BackgroundAttachmentFixed. rebaseline test. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index 21e0cf23ca90b6eff037af7b0827891c79cb7c5a..eadd59beadec883a7f87ec8434cf9e3fc868a656 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -254,7 +254,7 @@ void LayoutBox::styleDidChange(StyleDifference diff, const ComputedStyle* oldSty
if (LayoutMultiColumnSpannerPlaceholder* placeholder = this->spannerPlaceholder())
placeholder->layoutObjectInFlowThreadStyleDidChange(oldStyle);
- updateSlowRepaintStatusAfterStyleChange();
+ updateBackgroundAttachmentFixedStatusAfterStyleChange();
if (oldStyle) {
LayoutFlowThread* flowThread = flowThreadContainingBlock();
@@ -263,7 +263,7 @@ void LayoutBox::styleDidChange(StyleDifference diff, const ComputedStyle* oldSty
}
}
-void LayoutBox::updateSlowRepaintStatusAfterStyleChange()
+void LayoutBox::updateBackgroundAttachmentFixedStatusAfterStyleChange()
{
if (!frameView())
return;
@@ -277,15 +277,15 @@ void LayoutBox::updateSlowRepaintStatusAfterStyleChange()
return;
// An object needs to be repainted on frame scroll when it has background-attachment:fixed.
- // LayoutObject is responsible for painting root background, thus the root element (and the
+ // LayoutView is responsible for painting root background, thus the root element (and the
// body element if html element has no background) skips painting backgrounds.
- bool isSlowRepaintObject = !isDocumentElement() && !backgroundStolenForBeingBody() && styleRef().hasFixedBackgroundImage();
+ bool isBackgroundAttachmentFixedObject = !isDocumentElement() && !backgroundStolenForBeingBody() && styleRef().hasFixedBackgroundImage();
if (isLayoutView() && view()->compositor()->supportsFixedRootBackgroundCompositing()) {
if (styleRef().hasEntirelyFixedBackground())
- isSlowRepaintObject = false;
+ isBackgroundAttachmentFixedObject = false;
}
- setIsSlowRepaintObject(isSlowRepaintObject);
+ setIsBackgroundAttachmentFixedObject(isBackgroundAttachmentFixedObject);
}
void LayoutBox::updateShapeOutsideInfoAfterStyleChange(const ComputedStyle& style, const ComputedStyle* oldStyle)
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698