net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl().

net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl().

For historical reasons, URLRequestMockHTTPJob::GetMockUrl() and
GetMockHttpsUrl() take a base::FilePath even though the only thing they
do with it is call path.MaybeAsASCII() on it. All the unittests using them
have to do ugly things with FILE_PATH_LITERAL when calling.

This patch fixes the only file using the FilePath version of GetMockUrl().

BUG=496936
TEST=browser_tests && unit_tests
R=mattm@chromium.org,mmenke@chromium.org
TBR=thestig@chromium.org,avi@chromium.org

Committed: https://crrev.com/5e7b57230f8fccaaf2ecd0cfc62869de629678e4
Cr-Commit-Position: refs/heads/master@{#354691}

[tfarina, 2015-10-08 20:53:14]

Matt, PTAL!

[tfarina, 2015-10-14 16:33:36]

Ping!

[mmenke, 2015-10-14 16:43:19]

mmenke@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2015-10-14 16:43:20]

Can any Matt review this, or just particular Matts?  LGTM

https://codereview.chromium.org/1391423002/diff/140001/chrome/browser/downloa...
File chrome/browser/download/download_browsertest.cc (right):

https://codereview.chromium.org/1391423002/diff/140001/chrome/browser/downloa...
chrome/browser/download/download_browsertest.cc:1131: GURL
url(URLRequestMockHTTPJob::GetMockUrl("download-test1.lib"));
Suggest making the path a constant char[] (Either a per-test constant or at the
top with the other constants)

https://codereview.chromium.org/1391423002/diff/140001/chrome/browser/downloa...
File chrome/browser/download/save_page_browsertest.cc (right):

https://codereview.chromium.org/1391423002/diff/140001/chrome/browser/downloa...
chrome/browser/download/save_page_browsertest.cc:529:
test_dir_.Append(base::FilePath(kTestDir)).Append(file_name),
Maybe AppendASCII and get rid of file_name?

[tfarina, 2015-10-17 22:24:43]

tfarina@chromium.org changed reviewers:
+ avi@chromium.org, thestig@chromium.org

[tfarina, 2015-10-17 22:24:44]

TBRing Lei for chrome and Avi for content.

https://codereview.chromium.org/1391423002/diff/140001/chrome/browser/downloa...
File chrome/browser/download/download_browsertest.cc (right):

https://codereview.chromium.org/1391423002/diff/140001/chrome/browser/downloa...
chrome/browser/download/download_browsertest.cc:1131: GURL
url(URLRequestMockHTTPJob::GetMockUrl("download-test1.lib"));
On 2015/10/14 16:43:20, mmenke wrote:
> Suggest making the path a constant char[] (Either a per-test constant or at
the
> top with the other constants)

Done.

https://codereview.chromium.org/1391423002/diff/140001/chrome/browser/downloa...
File chrome/browser/download/save_page_browsertest.cc (right):

https://codereview.chromium.org/1391423002/diff/140001/chrome/browser/downloa...
chrome/browser/download/save_page_browsertest.cc:529:
test_dir_.Append(base::FilePath(kTestDir)).Append(file_name),
On 2015/10/14 16:43:20, mmenke wrote:
> Maybe AppendASCII and get rid of file_name?

Done.

[tfarina, 2015-10-17 22:25:28]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-10-17 22:25:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1391423002/#ps160001
(title: "mmenke review")

[commit-bot: I haz the power, 2015-10-17 22:25:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1391423002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1391423002/160001

[commit-bot: I haz the power, 2015-10-17 23:37:48]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2015-10-17 23:38:59]

Patchset 9 (id:??) landed as
https://crrev.com/5e7b57230f8fccaaf2ecd0cfc62869de629678e4
Cr-Commit-Position: refs/heads/master@{#354691}

[Avi (use Gerrit), 2015-10-18 00:03:06]

lgtm

[Lei Zhang, 2015-10-18 03:41:21]

lgtm