chrome/browser/lifetime/browser_close_manager_browsertest.cc - Issue 1391423002: net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/lifetime/browser_close_manager_browsertest.cc

Issue 1391423002: net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mmenke review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc ('k') | chrome/browser/net/dns_probe_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/lifetime/browser_close_manager_browsertest.cc

diff --git a/chrome/browser/lifetime/browser_close_manager_browsertest.cc b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

index 0eab958f094ee2fa911eb3588012cdc5f09d11cb..270b10df49a68c3d508736f2c1e0cfa216dcf169 100644

--- a/chrome/browser/lifetime/browser_close_manager_browsertest.cc

+++ b/chrome/browser/lifetime/browser_close_manager_browsertest.cc

@@ -765,8 +765,8 @@ IN_PROC_BROWSER_TEST_P(BrowserCloseManagerWithDownloadsBrowserTest,

// Run a dangerous download, but the user doesn't make a decision.

// This .swf normally would be categorized as DANGEROUS_FILE, but

// TestDownloadManagerDelegate turns it into DANGEROUS_URL.

- base::FilePath file(FILE_PATH_LITERAL("downloads/dangerous/dangerous.swf"));

- GURL download_url(net::URLRequestMockHTTPJob::GetMockUrl(file));

+ GURL download_url(net::URLRequestMockHTTPJob::GetMockUrl(

+ "downloads/dangerous/dangerous.swf"));

content::DownloadTestObserverInterrupted observer(

content::BrowserContext::GetDownloadManager(browser()->profile()),