chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc - Issue 1391423002: net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

Issue 1391423002: net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mmenke review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/errorpage_browsertest.cc ('k') | chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

diff --git a/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc b/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

index 0896dfaa3515b0d4bffcdcdf346039b5b08bb131..4022bf94fc6424044ff15f9dea2457fd1a11045f 100644

--- a/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

+++ b/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc

@@ -95,8 +95,8 @@ class EnterpriseDeviceAttributesTest : public ExtensionApiTest {

// manifest that includes the crx file of the test extension.

base::FilePath update_manifest_path =

base::FilePath(kTestExtensionDir).Append(kUpdateManifestFileName);

- GURL update_manifest_url(

- net::URLRequestMockHTTPJob::GetMockUrl(update_manifest_path));

+ GURL update_manifest_url(net::URLRequestMockHTTPJob::GetMockUrl(

+ update_manifest_path.MaybeAsASCII()));

scoped_ptr<base::ListValue> forcelist(new base::ListValue);

forcelist->AppendString(base::StringPrintf(