net/test/url_request/url_request_mock_http_job.h - Issue 1391423002: net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/url_request/url_request_mock_http_job.h

Issue 1391423002: net: Remove FilePath version of URLRequestMockHTTPJob::GetMockUrl(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mmenke review Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/loader/resource_dispatcher_host_browsertest.cc ('k') | net/test/url_request/url_request_mock_http_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/test/url_request/url_request_mock_http_job.h

diff --git a/net/test/url_request/url_request_mock_http_job.h b/net/test/url_request/url_request_mock_http_job.h

index 127d07142c37755f2fb2299f77c507d4fb3efdb4..7a931fec5caad67de89a24ecbeffe329247e2fc1 100644

--- a/net/test/url_request/url_request_mock_http_job.h

+++ b/net/test/url_request/url_request_mock_http_job.h

@@ -51,10 +51,6 @@ class URLRequestMockHTTPJob : public URLRequestFileJob {

static GURL GetMockUrl(const std::string& path);

static GURL GetMockHttpsUrl(const std::string& path);

- // Like above, but takes a FilePath. These methods are deprecated. Prefer the

- // std::string versions. See http://crbug.com/496936.

- static GURL GetMockUrl(const base::FilePath& path);

// Returns a URLRequestJobFactory::ProtocolHandler that serves

// URLRequestMockHTTPJob's responding like an HTTP server. |base_path| is the

// file path leading to the root of the directory to use as the root of the