Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 1388503003: [NaCl SDK] Remove newlib toolchain from the SDK (Closed)

Created:
5 years, 2 months ago by Sam Clegg
Modified:
5 years, 2 months ago
Reviewers:
bradnelson, binji
CC:
binji+watch_chromium.org, chromium-reviews, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Remove newlib toolchain from the SDK We now have nacl-clang which is a far more modern compiler with C++11 support. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/ca78e94710d6eeaebc7bb1215ba15438ff3d0a10 Cr-Commit-Position: refs/heads/master@{#352433}

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -267 lines) Patch
M native_client_sdk/src/build_tools/build_artifacts.py View 1 2 7 chunks +6 lines, -41 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 2 4 chunks +3 lines, -6 lines 0 comments Download
M native_client_sdk/src/build_tools/extract_artifacts.py View 1 2 3 chunks +0 lines, -23 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 3 chunks +0 lines, -121 lines 0 comments Download
M native_client_sdk/src/build_tools/test_sdk.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/build_artifacts_test.py View 1 2 3 chunks +13 lines, -25 lines 0 comments Download
M native_client_sdk/src/build_tools/tests/parse_dsc_test.py View 2 chunks +4 lines, -4 lines 0 comments Download
M native_client_sdk/src/examples/demo/drive/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/earth/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/flock/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/life/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/nacl_io_demo/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/pi_generator/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/demo/voronoi/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/tutorial/debugging/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/tutorial/multi_platform/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/tutorial/testing/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/examples/tutorial/using_ppapi_simple/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/error_handling/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/ppapi_simple_cpp/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/libraries/xray/library.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_socket_test/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tests/sdk_util_test/example.dsc View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/tools/common.mk View 2 chunks +5 lines, -5 lines 0 comments Download
M native_client_sdk/src/tools/nacl_config.py View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M native_client_sdk/src/tools/nacl_gcc.mk View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M native_client_sdk/src/tools/tests/nacl_config_test.py View 1 2 4 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Sam Clegg
5 years, 2 months ago (2015-10-02 23:01:46 UTC) #3
binji
lgtm https://codereview.chromium.org/1388503003/diff/20001/native_client_sdk/src/build_tools/build_sdk.py File native_client_sdk/src/build_tools/build_sdk.py (right): https://codereview.chromium.org/1388503003/diff/20001/native_client_sdk/src/build_tools/build_sdk.py#newcode68 native_client_sdk/src/build_tools/build_sdk.py:68: 'arm_newlib': ('nacl_arm_newlib', '%(platform)s_arm_newlib', 'arm'), remove this too? https://codereview.chromium.org/1388503003/diff/20001/native_client_sdk/src/libraries/nacl_io/library.dsc ...
5 years, 2 months ago (2015-10-02 23:08:06 UTC) #4
bradnelson
lgtm aside from binji's comments YEAH!, one less toolchain
5 years, 2 months ago (2015-10-02 23:21:15 UTC) #5
Sam Clegg
Also, updated build_artifacts.py (here I also removed bionic support since that is on its way ...
5 years, 2 months ago (2015-10-02 23:42:51 UTC) #6
binji
On 2015/10/02 at 23:42:51, sbc wrote: > Also, updated build_artifacts.py (here I also removed bionic ...
5 years, 2 months ago (2015-10-03 05:07:14 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388503003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388503003/40001
5 years, 2 months ago (2015-10-05 17:31:31 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-05 21:19:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388503003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388503003/40001
5 years, 2 months ago (2015-10-05 21:24:15 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-05 21:36:08 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 21:37:18 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ca78e94710d6eeaebc7bb1215ba15438ff3d0a10
Cr-Commit-Position: refs/heads/master@{#352433}

Powered by Google App Engine
This is Rietveld 408576698