native_client_sdk/src/build_tools/test_sdk.py - Issue 1388503003: [NaCl SDK] Remove newlib toolchain from the SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/test_sdk.py

Issue 1388503003: [NaCl SDK] Remove newlib toolchain from the SDK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/build_tools/test_sdk.py

diff --git a/native_client_sdk/src/build_tools/test_sdk.py b/native_client_sdk/src/build_tools/test_sdk.py

index 7a4e774ed97c307021be5098dc1e4832f745b22f..355df2859b57e45e5a5384fb1cad88b58e698bbf 100755

--- a/native_client_sdk/src/build_tools/test_sdk.py

+++ b/native_client_sdk/src/build_tools/test_sdk.py

@@ -126,7 +126,7 @@ def StepRunSelLdrTests(pepperdir, sanitizer):

if sanitizer:

continue

- for toolchain in ('clang-newlib', 'newlib', 'glibc', 'pnacl'):

+ for toolchain in ('clang-newlib', 'glibc', 'pnacl'):

for arch in archs:

# TODO(sbc): Remove this once we get elf_loader.nexe added to the SDK

if toolchain == 'glibc' and arch == 'arm':

@@ -184,7 +184,7 @@ def main(args):

pepper_ver = str(int(build_version.ChromeMajorVersion()))

pepperdir = os.path.join(OUT_DIR, 'pepper_' + pepper_ver)

- toolchains = ['clang-newlib', 'newlib', 'glibc', 'pnacl']

+ toolchains = ['clang-newlib', 'glibc', 'pnacl']

toolchains.append(getos.GetPlatform())

if options.verbose: